Bug 39005 - Web Inspector: disabling style property on container breaks styles inspection for given node.
Summary: Web Inspector: disabling style property on container breaks styles inspection...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-05-12 10:48 PDT by Pavel Feldman
Modified: 2010-05-12 12:30 PDT (History)
7 users (show)

See Also:


Attachments
[PATCH] Proposed change. (23.97 KB, patch)
2010-05-12 11:02 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-05-12 10:48:06 PDT
In case one disabled inheritable property on container, subsequent inspection of the node is not providing results.
Comment 1 Pavel Feldman 2010-05-12 11:02:27 PDT
Created attachment 55870 [details]
[PATCH] Proposed change.

Inherited styles disabling is still not working as I'd like it to: in case inherited property is disabled, it won't show up in inherited list at all. But at least it is not failing for subsequent selections anymore + i added some styles mutation tests.
Comment 2 Timothy Hatcher 2010-05-12 11:14:02 PDT
<rdar://problem/7974912>
Comment 3 Pavel Feldman 2010-05-12 11:24:35 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/inspector/elements-img-tooltip.html
	M	LayoutTests/inspector/elements-panel-limited-children.html
	M	LayoutTests/inspector/elements-panel-rewrite-href.html
	M	LayoutTests/inspector/elements-panel-selection-on-refresh.html
	M	LayoutTests/inspector/elements-panel-structure.html
	M	LayoutTests/inspector/elements-panel-styles.html
	M	LayoutTests/inspector/elements-panel-xhtml-structure.xhtml
	M	LayoutTests/inspector/elements-tests.js
	A	LayoutTests/inspector/styles-disable-inherited-expected.txt
	A	LayoutTests/inspector/styles-disable-inherited.html
	A	LayoutTests/inspector/styles-disable-then-enable-expected.txt
	A	LayoutTests/inspector/styles-disable-then-enable.html
	M	LayoutTests/inspector/styles-iframe.html
	M	LayoutTests/inspector/styles-source-lines.html
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/StylesSidebarPane.js
Committed r59243
Comment 4 WebKit Review Bot 2010-05-12 12:30:36 PDT
http://trac.webkit.org/changeset/59243 might have broken Leopard Intel Release (Tests) and GTK Linux 64-bit Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/59243
http://trac.webkit.org/changeset/59244
http://trac.webkit.org/changeset/59245
http://trac.webkit.org/changeset/59246