Bug 39001 - IDBRequest is not a proper ActiveDomObject
Summary: IDBRequest is not a proper ActiveDomObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 39167
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-12 09:54 PDT by Andrei Popescu
Modified: 2010-05-17 06:34 PDT (History)
6 users (show)

See Also:


Attachments
Fix IDBRequest. (2.93 KB, patch)
2010-05-12 10:07 PDT, Andrei Popescu
jorlow: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Popescu 2010-05-12 09:54:06 PDT
1. IDBRequest interface is not mentioned in the IsActiveDomType routine of the CodeGeneratorV8.pm
2. IDBRequest class should rename its m_stopped member to m_suspended and this flag should be reset when resume() is called.

Patch following.
Comment 1 Andrei Popescu 2010-05-12 10:07:18 PDT
Created attachment 55865 [details]
Fix IDBRequest.
Comment 2 Jeremy Orlow 2010-05-12 10:12:18 PDT
Comment on attachment 55865 [details]
Fix IDBRequest.

r=me
Comment 3 WebKit Commit Bot 2010-05-15 12:53:16 PDT
Comment on attachment 55865 [details]
Fix IDBRequest.

Clearing flags on attachment: 55865

Committed r59549: <http://trac.webkit.org/changeset/59549>
Comment 4 WebKit Commit Bot 2010-05-15 12:53:21 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-05-15 13:06:19 PDT
http://trac.webkit.org/changeset/59549 might have broken Chromium Linux Release
Comment 6 Adam Barth 2010-05-15 13:19:08 PDT
Too bad the EWS didn't run on this patch.  :(  Rolling out.
Comment 7 Adam Barth 2010-05-15 13:19:56 PDT
Reopening.
Comment 8 Eric Seidel (no email) 2010-05-15 13:36:23 PDT
Thank you Adam.
Comment 9 Andrei Popescu 2010-05-17 01:51:23 PDT
Oops, sorry about this. Fixing.
Comment 10 Jeremy Orlow 2010-05-17 06:34:05 PDT
Landed http://trac.webkit.org/changeset/59605