Bug 38997 – REGRESSION: webkit-patch commit-message throws exception

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Seidel (no email)]

webkit-patch commit-message throws exception

It's mostly used for testing.  Seems it needs to have --squash and --git-commit added as options.

% webkit-patch commit-message
Traceback (most recent call last):
  File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 56, in <module>
    main()
  File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 51, in main
    WebKitPatch(__file__).main()
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 302, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 113, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/commands/upload.py", line 56, in execute
    print "%s" % tool.checkout().commit_message_for_this_commit().message()
TypeError: commit_message_for_this_commit() takes exactly 3 arguments (1 given)

[Eric Seidel (no email)]

Created attachment 55861 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 55861 [details]
Patch

Rejecting patch 55861 from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact [e-mail] to request a commit-queue restart.  After restart the commit-queue will correctly respect your reviewer rights.

[Adam Barth]

Comment on attachment 55861 [details]
Patch

Looks like ojan isn't registered as a proper reviewer yet.

[WebKit Commit Bot]

Comment on attachment 55861 [details]
Patch

Clearing flags on attachment: 55861

Committed r59461: <http://trac.webkit.org/changeset/59461>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.