Bug 38991 - HTMLLabelElement::control() should return HTMLFormControlElement, not HTMLElement
Summary: HTMLLabelElement::control() should return HTMLFormControlElement, not HTMLEle...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-12 07:43 PDT by Yael
Modified: 2010-05-12 12:12 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.78 KB, patch)
2010-05-12 07:48 PDT, Yael
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2010-05-12 07:43:28 PDT
This is from the comment https://bugs.webkit.org/show_bug.cgi?id=38688#c18.
This change cannot remove type casting in the code, but it is still the right thing to do.
Comment 1 Yael 2010-05-12 07:48:46 PDT
Created attachment 55844 [details]
Patch
Comment 2 mitz 2010-05-12 08:02:43 PDT
Comment on attachment 55844 [details]
Patch

> +#include "HTMLFormControlElement.h"

I think a forward declaration of the class will suffice here, instead of including the header.
Comment 3 Yael 2010-05-12 08:20:03 PDT
(In reply to comment #2)
> (From update of attachment 55844 [details])
> > +#include "HTMLFormControlElement.h"
> 
> I think a forward declaration of the class will suffice here, instead of including the header.

Thanks for your review.
I added the header due to problem compiling DOMHTMLLabelElement.mm. Perhaps there was a better way to fix the compile error.
Comment 4 Yael 2010-05-12 12:11:42 PDT
Committed r59248: <http://trac.webkit.org/changeset/59248>