Bug 38989 – [Qt] Remove the unneeded check for QWidgetPageClient @QGraphicsWebView::detachCurrentPage

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Antonio Gomes]

Bug title says it all.

Reasons:
- There is no need to check for a QWidgetPageClient-based in QGraphicsWebView.
- The client has always to be deleted anyways.

patch coming ...

[Antonio Gomes]

Created attachment 55840 [details]
patch v1

[Jesus Sanchez-Palencia]

(In reply to comment #1)
> Created an attachment (id=55840) [details]
> patch v1

I missed that on my PageClient patches. =/
Thanks! LGTM, just remember to add the bug number to the Changelog. :)

[Jesus Sanchez-Palencia]

If we want this to go into the 2.0 release we would need to cherry-pick the PageClient refactor first.
https://bugs.webkit.org/show_bug.cgi?id=37856

[Antonio Gomes]

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=55840) [details] [details]
> > patch v1
> 
> I missed that on my PageClient patches. =/
> Thanks! LGTM, just remember to add the bug number to the Changelog. :)

I can fix that while landing (it is done locally already). Thank you.

(In reply to comment #3)
> If we want this to go into the 2.0 release we would need to cherry-pick the PageClient refactor first.
> https://bugs.webkit.org/show_bug.cgi?id=37856

Sure, removing the block for now.

[Kenneth Rohde Christiansen]

Comment on attachment 55840 [details]
patch v1

WebKit/qt/Api/qgraphicswebview.cpp:451
 +          delete page->d->client;
No need to use an if, delete'ing a null pointer does nothing.

[Antonio Gomes]

Created attachment 55843 [details]
patch v2

as requested:

- Adds the bugzilla entry to the ChangeLog
- Removes the "if" wrapping the delete

[Antonio Gomes]

Committed r59234: <http://trac.webkit.org/changeset/59234>