Bug title says it all. Reasons: - There is no need to check for a QWidgetPageClient-based in QGraphicsWebView. - The client has always to be deleted anyways. patch coming ...
Created attachment 55840 [details] patch v1
(In reply to comment #1) > Created an attachment (id=55840) [details] > patch v1 I missed that on my PageClient patches. =/ Thanks! LGTM, just remember to add the bug number to the Changelog. :)
If we want this to go into the 2.0 release we would need to cherry-pick the PageClient refactor first. https://bugs.webkit.org/show_bug.cgi?id=37856
(In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=55840) [details] [details] > > patch v1 > > I missed that on my PageClient patches. =/ > Thanks! LGTM, just remember to add the bug number to the Changelog. :) I can fix that while landing (it is done locally already). Thank you. (In reply to comment #3) > If we want this to go into the 2.0 release we would need to cherry-pick the PageClient refactor first. > https://bugs.webkit.org/show_bug.cgi?id=37856 Sure, removing the block for now.
Comment on attachment 55840 [details] patch v1 WebKit/qt/Api/qgraphicswebview.cpp:451 + delete page->d->client; No need to use an if, delete'ing a null pointer does nothing.
Created attachment 55843 [details] patch v2 as requested: - Adds the bugzilla entry to the ChangeLog - Removes the "if" wrapping the delete
Committed r59234: <http://trac.webkit.org/changeset/59234>