Bug 38978 - [chromium] add DRT back to the chromium build
Summary: [chromium] add DRT back to the chromium build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-12 00:11 PDT by Tony Chang
Modified: 2010-05-12 00:46 PDT (History)
0 users

See Also:


Attachments
Patch (9.63 KB, patch)
2010-05-12 00:12 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch (9.72 KB, patch)
2010-05-12 00:25 PDT, Tony Chang
tkent: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-05-12 00:11:13 PDT
[chromium] add DRT back to the chromium build
Comment 1 Tony Chang 2010-05-12 00:12:03 PDT
Created attachment 55812 [details]
Patch
Comment 2 Kent Tamura 2010-05-12 00:20:13 PDT
Comment on attachment 55812 [details]
Patch

> diff --git a/WebKit/chromium/WebKit.gyp b/WebKit/chromium/WebKit.gyp
> index fe2d5890f787b4db96d6b8959820b4b0ec30e2c2..be69a572129ff052158fd191304bb497b7f3715f 100644
> --- a/WebKit/chromium/WebKit.gyp
> +++ b/WebKit/chromium/WebKit.gyp
> @@ -535,6 +535,85 @@
>              ],
>          },
>          {
> +            'target_name': 'DumpRenderTree',
> +            'type': 'executable',
> +            'mac_bundle': 1,
> +            'dependencies': [
> +                'webkit',
> +                '../../JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp:wtf_config',
> +                '<(chromium_src_dir)/third_party/icu/icu.gyp:icuuc',
> +                '<(webkit_support_gyp):webkit_support',
> +            ],
> +            'include_dirs': [
> +                '.',
> +                '../../JavaScriptCore',
> +                '<(DEPTH)',
> +            ],

'include_dirs' without this patch contains 4 lines. It seems a line was removed accidentally.
Comment 3 Tony Chang 2010-05-12 00:25:23 PDT
Created attachment 55813 [details]
Patch
Comment 4 Tony Chang 2010-05-12 00:26:22 PDT
(In reply to comment #2)
> 'include_dirs' without this patch contains 4 lines. It seems a line was removed accidentally.

Sorry, you're right!  I've added the include path in the new patch.
Comment 5 Tony Chang 2010-05-12 00:46:21 PDT
Committed r59212: <http://trac.webkit.org/changeset/59212>