Bug 38961 - Move some member variables around to reduce class sizes.
Summary: Move some member variables around to reduce class sizes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-05-11 17:49 PDT by Anders Carlsson
Modified: 2010-05-12 21:00 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.50 KB, patch)
2010-05-11 17:51 PDT, Anders Carlsson
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-05-11 17:49:03 PDT
Move some member variables around to reduce class sizes.
Comment 1 Anders Carlsson 2010-05-11 17:51:24 PDT
Created attachment 55787 [details]
Patch
Comment 2 Mark Rowe (bdash) 2010-05-11 18:10:44 PDT
Comment on attachment 55787 [details]
Patch

Do we need comments in any of these places to warn people against moving these members back again?

r=me
Comment 3 David Levin 2010-05-11 18:15:40 PDT
(In reply to comment #2)
> (From update of attachment 55787 [details])
> Do we need comments in any of these places to warn people against moving these members back again?
> 
> r=me

The AtomicString change seems the most likely to be undone by accident as this change will break what http://trac.webkit.org/changeset/56100 tried to accomplish.
Comment 4 Anders Carlsson 2010-05-11 18:28:16 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 55787 [details] [details])
> > Do we need comments in any of these places to warn people against moving these members back again?
> > 
> > r=me
> 
> The AtomicString change seems the most likely to be undone by accident as this change will break what http://trac.webkit.org/changeset/56100 tried to accomplish.

We could add a compile time assert that sizeof(AtomicString) == sizeof(String).
Comment 5 Anders Carlsson 2010-05-11 19:28:39 PDT
Committed r59197: <http://trac.webkit.org/changeset/59197>
Comment 6 Alexey Proskuryakov 2010-05-11 20:26:58 PDT
> We could add a compile time assert that sizeof(AtomicString) == sizeof(String).

Anders added it in <http://trac.webkit.org/changeset/59198>.
Comment 7 David Kilzer (:ddkilzer) 2010-05-12 21:00:38 PDT
<rdar://problem/7978054>