RESOLVED FIXED 38961
Move some member variables around to reduce class sizes. 
https://bugs.webkit.org/show_bug.cgi?id=38961
Summary Move some member variables around to reduce class sizes.
Anders Carlsson
Reported 2010-05-11 17:49:03 PDT
Move some member variables around to reduce class sizes.
Attachments
Patch (6.50 KB, patch)
2010-05-11 17:51 PDT, Anders Carlsson 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-05-11 17:51:24 PDT
Created attachment 55787 [details] Patch
Mark Rowe (bdash)
Comment 2 2010-05-11 18:10:44 PDT
Comment on attachment 55787 [details] Patch Do we need comments in any of these places to warn people against moving these members back again? r=me
David Levin
Comment 3 2010-05-11 18:15:40 PDT
(In reply to comment #2) > (From update of attachment 55787 [details]) > Do we need comments in any of these places to warn people against moving these members back again? > > r=me The AtomicString change seems the most likely to be undone by accident as this change will break what http://trac.webkit.org/changeset/56100 tried to accomplish.
Anders Carlsson
Comment 4 2010-05-11 18:28:16 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 55787 [details] [details]) > > Do we need comments in any of these places to warn people against moving these members back again? > > > > r=me > > The AtomicString change seems the most likely to be undone by accident as this change will break what http://trac.webkit.org/changeset/56100 tried to accomplish. We could add a compile time assert that sizeof(AtomicString) == sizeof(String).
Anders Carlsson
Comment 5 2010-05-11 19:28:39 PDT
Committed r59197: <http://trac.webkit.org/changeset/59197>
Alexey Proskuryakov
Comment 6 2010-05-11 20:26:58 PDT
> We could add a compile time assert that sizeof(AtomicString) == sizeof(String). Anders added it in <http://trac.webkit.org/changeset/59198>.
David Kilzer (:ddkilzer)
Comment 7 2010-05-12 21:00:38 PDT
<rdar://problem/7978054>
Note You need to log in before you can comment on or make changes to this bug.