Bug 38950 - 19 media tests are crashing on Windows Release
Summary: 19 media tests are crashing on Windows Release
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Jer Noble
URL: http://build.webkit.org/builders/Wind...
Keywords: InRadar, LayoutTestFailure, PlatformOnly, Regression
Depends on:
Blocks:
 
Reported: 2010-05-11 16:54 PDT by Jer Noble
Modified: 2011-11-14 23:02 PST (History)
1 user (show)

See Also:


Attachments
QTMovieWin.vcproj: link against JavaScriptCore instead of WTF. (3.09 KB, patch)
2010-05-11 17:14 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
QTMovieWin.vcproj: link against JavaScriptCore instead of WTF. (3.80 KB, patch)
2010-05-11 17:20 PDT, Jer Noble
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2010-05-11 16:54:44 PDT
Since r59001, 19 media tests have been crashing on Windows Release.
Comment 1 Jer Noble 2010-05-11 17:14:16 PDT
Created attachment 55780 [details]
QTMovieWin.vcproj: link against JavaScriptCore instead of WTF.

Linking directly against WTF.lib instead of indirectly through JavaScriptCore.lib causes free and malloc to duplicated inside QTMovieWin.dll.  This causes a malloc/free mismatch which shows up only in Release builds.
Comment 2 Jer Noble 2010-05-11 17:15:10 PDT
This originally showed up in r59001 when QTMovie, QTMovieGWorld, and QTMovieVisualContext were changed to inherit from WTF::RefCounted, so that each could be contained in a RefPtr.
Comment 3 Jer Noble 2010-05-11 17:17:08 PDT
Testing 93 test cases.
media .............................................................................................
48.38s total testing time

all 93 test cases succeeded
Comment 4 Jer Noble 2010-05-11 17:20:58 PDT
Created attachment 55782 [details]
QTMovieWin.vcproj: link against JavaScriptCore instead of WTF.

This time, with a ChangeLog.
Comment 5 Jer Noble 2010-05-11 17:43:04 PDT
Committed r59190: <http://trac.webkit.org/changeset/59190>
Comment 6 Ryosuke Niwa 2011-11-14 23:02:57 PST
Fixed the change log entry in http://trac.webkit.org/changeset/100243.