Bug 38948 – Chromium regression in user gesture handling

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Chris Evans]

Full details at http://code.google.com/p/chromium/issues/detail?id=42643
Patch forthcoming.

[Chris Evans]

Created attachment 55778 [details]
Fix logic.

[Chris Evans]

Simple enough. This patch restores the original logic but with Adam's enum elegance :)
BTW, please r+ it but don't cq+ it. I want to test my new commit powers...

[Adam Barth]

Comment on attachment 55778 [details]
Fix logic.

Is this not testable?

[Chris Evans]

Yeah, it's not really testable as a layout test. Chromium does the popup blocking completely differently to the WebKit built-in blocker. Chromium actually runs with the WebKit blocker _disabled_ and does blocking in the UI.
I have a TODO to add a Chromium UI test for all these blocker corner cases once I've fixed them all.

[WebKit Commit Bot]

Comment on attachment 55778 [details]
Fix logic.

Rejecting patch 55778 from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact [e-mail] to request a commit-queue restart.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 55778 [details]
Fix logic.

Clearing flags on attachment: 55778

Committed r59462: <http://trac.webkit.org/changeset/59462>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.