WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
38944
check-webkit-style gives style error about DEFINE_GLOBAL macro
https://bugs.webkit.org/show_bug.cgi?id=38944
Summary
check-webkit-style gives style error about DEFINE_GLOBAL macro
Brian Weinstein
Reported
2010-05-11 15:50:27 PDT
JavaScriptCore/wtf/text/StringStatics.cpp:58: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] DEFINE_GLOBAL is a macro, and we have a lot of underscores in other macros, so this is a bug in check-webkit-style.
Attachments
Add attachment
proposed patch, testcase, etc.
Fujii Hironori
Comment 1
2017-11-02 16:09:39 PDT
DEFINE_GLOBAL was removed in
Bug 174979
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug