Bug 38944 - check-webkit-style gives style error about DEFINE_GLOBAL macro
Summary: check-webkit-style gives style error about DEFINE_GLOBAL macro
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-11 15:50 PDT by Brian Weinstein
Modified: 2017-11-02 16:09 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2010-05-11 15:50:27 PDT 
JavaScriptCore/wtf/text/StringStatics.cpp:58:  DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]

DEFINE_GLOBAL is a macro, and we have a lot of underscores in other macros, so this is a bug in check-webkit-style.
Comment 1 Fujii Hironori 2017-11-02 16:09:39 PDT 
DEFINE_GLOBAL was removed in Bug 174979.