Bug 38939 – [Qt] Implement a detachCurrentPage method for QGraphicsWebView and QWebView

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Antonio Gomes]

This detachPage method extands the current unsetPageIfExists implementation, by being responsible of unseting the view and client of the |page| -- it was done in QWebView and QGraphicsWebView destructor routines previously.

work is basically a code clean up and was idealized by kenneth originally.

patch coming...

[Antonio Gomes]

Created attachment 55764 [details]
patch v1

[Jesus Sanchez-Palencia]

(In reply to comment #1)
> Created an attachment (id=55764) [details]
> patch v1


LGTM, but from our earlier chat I thought that "if (page->d->client && page->d->client->isQWidgetClient())" was going to be removed from QGraphicsWebViewPrivate::unsetPageIfExists() .

Did you miss that or am I just wrong?!

[Antonio Gomes]

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=55764) [details] [details]
> > patch v1
> 
> 
> LGTM, but from our earlier chat I thought that "if (page->d->client && page->d->client->isQWidgetClient())" was going to be removed from QGraphicsWebViewPrivate::unsetPageIfExists() .
> 
> Did you miss that or am I just wrong?!

Thank you, Jesus. The other patch is coming next to this, in a separated pAtch

[Kenneth Rohde Christiansen]

Comment on attachment 55764 [details]
patch v1

Maybe use detachCurrentPage? I would also like an autotest actually testing the fix you did for always clearing the view when setting a new page, but it can be a separate patch.

[Antonio Gomes]

Committed r59233: <http://trac.webkit.org/changeset/59233>