Bug 38913 - REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works
Summary: REGRESSION(r58520): Implicit submission on forms with button type="submit" no...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords: InRadar
Depends on:
Blocks: 39021
  Show dependency treegraph
 
Reported: 2010-05-11 09:28 PDT by Dimitri Glazkov (Google)
Modified: 2010-05-22 10:49 PDT (History)
2 users (show)

See Also:


Attachments
Patch (11.72 KB, patch)
2010-05-11 10:49 PDT, Dimitri Glazkov (Google)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2010-05-11 09:28:37 PDT
REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works
Comment 1 Dimitri Glazkov (Google) 2010-05-11 10:31:25 PDT
Turns out my super-duper test had incomplete coverage. 

http://www.shacknews.com/search.x?terms=abcdef&type=comments no longer implicitly submits.

Patch coming up.
Comment 2 Dimitri Glazkov (Google) 2010-05-11 10:49:09 PDT
Created attachment 55720 [details]
Patch
Comment 3 Darin Adler 2010-05-11 10:55:57 PDT
Comment on attachment 55720 [details]
Patch

I would have preferred to see the bug fix separate from the cleanup. Clearly all that was needed to fix the bug was to check isSuccessfulSubmitButton even when the element is not an <input>. And the renaming and refactoring obscures that change.

The final resulting code looks great.

r=me
Comment 4 Alexey Proskuryakov 2010-05-11 11:05:34 PDT
<rdar://problem/7969230>
Comment 5 Dimitri Glazkov (Google) 2010-05-11 11:09:42 PDT
I apologize, I started with a fix and then it was looking uglier and uglier. I have another patch that makes it even less ugly, but I'll land this first, then lick it some more.
Comment 6 Dimitri Glazkov (Google) 2010-05-11 15:01:37 PDT
Committed r59173: <http://trac.webkit.org/changeset/59173>