REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works
Turns out my super-duper test had incomplete coverage.
http://www.shacknews.com/search.x?terms=abcdef&type=comments no longer implicitly submits.
Patch coming up.
Created attachment 55720 [details]
Comment on attachment 55720 [details]
I would have preferred to see the bug fix separate from the cleanup. Clearly all that was needed to fix the bug was to check isSuccessfulSubmitButton even when the element is not an <input>. And the renaming and refactoring obscures that change.
The final resulting code looks great.
I apologize, I started with a fix and then it was looking uglier and uglier. I have another patch that makes it even less ugly, but I'll land this first, then lick it some more.
Committed r59173: <http://trac.webkit.org/changeset/59173>