Bug 38911 – [Qt] Patch to locate Java plugin DLL on Windows via its Registry...

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[Dawit A.]

The following patch was split out from bug 33044 to make it easier to review on its own. Besides minor clean ups, this is the exact code from afformentioned bug report.

[Dawit A.]

Created attachment 55711 [details]
Patch to locate Windows Java plugin DLL via registry...

[Dawit A.]

Created attachment 55841 [details]
Locate Java plugin dll via the Windows Registry...

Corrected the entry in WebCore/ChangLog...

[Kenneth Rohde Christiansen]

Adam, can you look at the Windows part of this patch, or indicate a reviewer?

[Adam Roben (:aroben)]

Safari comes with its own Java plug-in. I don't think we'd want to use any other Java plug-in.

Jon Honeycutt and Anders Carlsson are the right people to look at this.

[Dawit A.]

(In reply to comment #4)
> Safari comes with its own Java plug-in. I don't think we'd want to use any other 
> Java plug-in.

I can #ifdef the patch to make it only apply to QtWebKit in case others, e.g. chrome, do the similar things as Safari. That way everyone that needs this has to opt-in and activate it for their own port ?

[Simon Hausmann]

(In reply to comment #5)
> (In reply to comment #4)
> > Safari comes with its own Java plug-in. I don't think we'd want to use any other 
> > Java plug-in.
> 
> I can #ifdef the patch to make it only apply to QtWebKit in case others, e.g. chrome, do the similar things as Safari. That way everyone that needs this has to opt-in and activate it for their own port ?

Sounds like a good idea, just wrap the call to the function in #if PLATFORM(QT).

[Dawit A.]

Created attachment 56391 [details]
Locate Java plugin dll via the Windows Registry (Update III)

Wrapped the call to "addJavaPluginDirectory" from "defaultPluginDirectories" with #if PLATFORM(QT)...

[WebKit Review Bot]

Attachment 56391 [details] did not build on win:
Build output: http://webkit-commit-queue.appspot.com/results/2291375

[Adam Barth]

Comment on attachment 56391 [details]
Locate Java plugin dll via the Windows Registry (Update III)

The windows failure scares me.  Probably best to land by hand.

[Dawit A.]

(In reply to comment #9)
> (From update of attachment 56391 [details])
> The windows failure scares me.  Probably best to land by hand.

The problem with the Windows build failure is that the log produced is worthless. It does not tell you anything so you cannot even begin to evaluate why it failed and provide a fix if necessary...

[Dawit A.]

Created attachment 65219 [details]
Locate Java plugin dll via the Windows Registry (Update IV)

Let us see if it compiles fine on Windows this time around...

[Eric Seidel (no email)]

Comment on attachment 56391 [details]
Locate Java plugin dll via the Windows Registry (Update III)

Cleared Simon Hausmann's review+ from obsolete attachment 56391 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Simon Hausmann]

Comment on attachment 65219 [details]
Locate Java plugin dll via the Windows Registry (Update IV)

r=me

[WebKit Commit Bot]

Comment on attachment 65219 [details]
Locate Java plugin dll via the Windows Registry (Update IV)

Clearing flags on attachment: 65219

Committed r66234: <http://trac.webkit.org/changeset/66234>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/66234 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/66233
http://trac.webkit.org/changeset/66234

[Ademar Reis]

Blocking QtWebKit 2.1 on this. See https://bugs.webkit.org/show_bug.cgi?id=33044#c30 for more information.

[Ademar Reis]

Revision r66234 cherry-picked into qtwebkit-2.1 with commit 8c6f4ae <http://gitorious.org/webkit/qtwebkit/commit/8c6f4ae>