Bug 38907 - PluginView contains JSC-specific code
Summary: PluginView contains JSC-specific code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-11 07:23 PDT by Steve Block
Modified: 2010-05-20 02:06 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.80 KB, patch)
2010-05-11 08:44 PDT, Steve Block 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-05-11 07:23:16 PDT 
PluginView contains JSC-specific code. This causes build errors on Android, which can use JSC or V8.

This can be solved by guarding calls to JSLock with USE(JSC) and refactoring to use platform independent methods.
Comment 1 Steve Block 2010-05-11 08:44:57 PDT 
Created attachment 55705 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-05-20 01:18:50 PDT 
Comment on attachment 55705 [details]
Patch

LGTM.
Comment 3 Steve Block 2010-05-20 02:06:21 PDT 
Comment on attachment 55705 [details]
Patch

Clearing flags on attachment: 55705

Committed r59826: <http://trac.webkit.org/changeset/59826>
Comment 4 Steve Block 2010-05-20 02:06:31 PDT 
All reviewed patches have been landed.  Closing bug.