WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
38907
PluginView contains JSC-specific code
https://bugs.webkit.org/show_bug.cgi?id=38907
Summary
PluginView contains JSC-specific code
Steve Block
Reported
2010-05-11 07:23:16 PDT
PluginView contains JSC-specific code. This causes build errors on Android, which can use JSC or V8. This can be solved by guarding calls to JSLock with USE(JSC) and refactoring to use platform independent methods.
Attachments
Patch
(5.80 KB, patch)
2010-05-11 08:44 PDT
,
Steve Block
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Steve Block
Comment 1
2010-05-11 08:44:57 PDT
Created
attachment 55705
[details]
Patch
Eric Seidel (no email)
Comment 2
2010-05-20 01:18:50 PDT
Comment on
attachment 55705
[details]
Patch LGTM.
Steve Block
Comment 3
2010-05-20 02:06:21 PDT
Comment on
attachment 55705
[details]
Patch Clearing flags on attachment: 55705 Committed
r59826
: <
http://trac.webkit.org/changeset/59826
>
Steve Block
Comment 4
2010-05-20 02:06:31 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug