Bug 38905 - Include missing header - PageGroup.h
Summary: Include missing header - PageGroup.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-11 06:59 PDT by Lucas De Marchi
Modified: 2010-05-14 01:44 PDT (History)
2 users (show)

See Also:


Attachments
Include missing header (914 bytes, patch)
2010-05-11 07:00 PDT, Lucas De Marchi
lucas.de.marchi: review-
lucas.de.marchi: commit-queue-
Details | Formatted Diff | Diff
Include missing header (914 bytes, patch)
2010-05-11 09:11 PDT, Lucas De Marchi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas De Marchi 2010-05-11 06:59:00 PDT
PageGroup.h is needed in function ewk_init and was missing in ewk_main.cpp.
Comment 1 Lucas De Marchi 2010-05-11 07:00:45 PDT
Created attachment 55700 [details]
Include missing header

This patch fixes this bug.
Comment 2 Jeremy Orlow 2010-05-11 07:09:03 PDT
Comment on attachment 55700 [details]
Include missing header

r=me
Comment 3 Lucas De Marchi 2010-05-11 09:05:10 PDT
Comment on attachment 55700 [details]
Include missing header

patch is malformed
Comment 4 Lucas De Marchi 2010-05-11 09:11:34 PDT
Created attachment 55709 [details]
Include missing header

Prior patch was malformed. This one fix the problem.
Comment 5 WebKit Commit Bot 2010-05-12 05:36:09 PDT
Comment on attachment 55709 [details]
Include missing header

Rejecting patch 55709 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Last 500 characters of output:
 that name could be found
Testing 18333 test cases.
media/video-loop.html -> timed out
Sampling process 64560 for 10 seconds with 10 milliseconds of run time between samples
Sampling completed, processing symbols...
Sample analysis of process 64560 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt

Exiting early after 1 failures. 14929 tests run.
349.25s total testing time

14928 test cases (99%) succeeded
1 test case (<1%) timed out
11 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/2172155
Comment 6 Gustavo Sverzut Barbieri 2010-05-12 05:43:43 PDT
Could someone (Eric?) check that, given the patch it is clearly not related to this patch. The patch just touches WebKit/efl/ewk/ewk_main.cpp!
Comment 7 Eric Seidel (no email) 2010-05-12 08:47:00 PDT
Comment on attachment 55709 [details]
Include missing header

This was bug 38912.
Comment 8 WebKit Commit Bot 2010-05-14 01:44:52 PDT
Comment on attachment 55709 [details]
Include missing header

Clearing flags on attachment: 55709

Committed r59453: <http://trac.webkit.org/changeset/59453>
Comment 9 WebKit Commit Bot 2010-05-14 01:44:57 PDT
All reviewed patches have been landed.  Closing bug.