Bug 38898 - Remove unnecessary jump in Yarr JIT's code
Summary: Remove unnecessary jump in Yarr JIT's code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-11 05:03 PDT by Peter Varga
Modified: 2010-05-12 04:49 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch (2.53 KB, patch)
2010-05-11 05:08 PDT, Peter Varga
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Varga 2010-05-11 05:03:20 PDT
The Yarr JIT generates an unnecessary jump in case of greedy character and
characterclass matching when it checks the count of repetitions.
It should be removed, because it is followed by a direct jump
instead of a branch if the greedy term's quantityCount doesn't have max limit.
Comment 1 Peter Varga 2010-05-11 05:08:29 PDT
Created attachment 55689 [details]
proposed patch
Comment 2 Zoltan Horvath 2010-05-12 04:40:25 PDT
Comment on attachment 55689 [details]
proposed patch

Setting cq+.
Comment 3 Zoltan Horvath 2010-05-12 04:49:50 PDT
Comment on attachment 55689 [details]
proposed patch

Clearing flags on attachment: 55689

Committed r59222: <http://trac.webkit.org/changeset/59222>
Comment 4 Zoltan Horvath 2010-05-12 04:49:59 PDT
All reviewed patches have been landed.  Closing bug.