Bug 38889 - [chromium] don't build DRT in chromium checkouts due to a circular gyp dependency
Summary: [chromium] don't build DRT in chromium checkouts due to a circular gyp depend...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 23:50 PDT by Tony Chang
Modified: 2010-05-11 08:01 PDT (History)
2 users (show)

See Also:


Attachments
Patch (9.26 KB, patch)
2010-05-10 23:50 PDT, Tony Chang
tkent: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-05-10 23:50:26 PDT
[chromium] don't build DRT in chromium checkouts due to a circular gyp dependency
Comment 1 Tony Chang 2010-05-10 23:50:48 PDT
Created attachment 55670 [details]
Patch
Comment 2 Tony Chang 2010-05-10 23:52:07 PDT
This is unfortunate, but there's currently a circular dependency if you try to build DRT in a chromium checkout.  Disabling for now until we can work out a gyp refactoring to avoid this.
Comment 3 Kent Tamura 2010-05-11 00:09:05 PDT
What circulation occurs for now?
Comment 4 Tony Chang 2010-05-11 00:14:15 PDT
(In reply to comment #3)
> What circulation occurs for now?

webkit.gyp:pull_in_webkit_unit_tests -> WebKit.gyp -> webkit.gyp:webkit_support.

I'm not sure why we need pull_in_webkit_unit_tests, but I figure I should fix the build before trying to fix the circular dependency.
Comment 5 Tony Chang 2010-05-11 00:16:15 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > What circulation occurs for now?
> 
> webkit.gyp:pull_in_webkit_unit_tests -> WebKit.gyp -> webkit.gyp:webkit_support.
> 
> I'm not sure why we need pull_in_webkit_unit_tests, but I figure I should fix the build before trying to fix the circular dependency.

According to the changelog, this is needed to add webkit_unit_tests to webkit.sln and chrome.sln.  Hmm, maybe this can be windows only since the circular gyp check only happens on mac.
Comment 6 Kent Tamura 2010-05-11 00:19:47 PDT
Comment on attachment 55670 [details]
Patch

Ok, I understand.
Comment 7 Tony Chang 2010-05-11 00:24:29 PDT
Committed r59145: <http://trac.webkit.org/changeset/59145>
Comment 8 Tony Chang 2010-05-11 00:27:08 PDT
There's also a dependency from test_shell.gypi to WebKit.gyp, but I think that can be solved by moving test_shell.gypi to test_shell.gyp and having a pull_in_test_shell target for windows.
Comment 9 Darin Fisher (:fishd, Google) 2010-05-11 08:01:11 PDT
> I'm not sure why we need pull_in_webkit_unit_tests, but I figure I should fix the build before trying to fix the circular dependency.

In chromium, trunk/src/webkit/webkit.gyp should pull in everything related to webkit so that if you are just doing webkit development, you can just use that.  I don't see why that should be Windows only.

Maybe we can leverage the inside_chromium_build variable to help resolve some of these issues.