Bug 38884 - test-webkitpy fails on windows due to lack of readline module
Summary: test-webkitpy fails on windows due to lack of readline module
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 20:14 PDT by Eric Seidel (no email)
Modified: 2010-05-12 21:12 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.12 KB, patch)
2010-05-10 20:17 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-05-10 20:14:59 PDT
test-webkitpy fails on windows due to lack of readline module
Comment 1 Eric Seidel (no email) 2010-05-10 20:17:39 PDT
Created attachment 55651 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-05-10 20:18:54 PDT
This brings us one step closer to test-webkitpy working under Win32 python.
Comment 3 Adam Barth 2010-05-10 20:30:01 PDT
Comment on attachment 55651 [details]
Patch

ok
Comment 4 Eric Seidel (no email) 2010-05-10 20:34:31 PDT
We could autoinstall http://newcenturycomputers.net/projects/readline.html on win32 python if necessary.
Comment 5 WebKit Commit Bot 2010-05-12 21:12:30 PDT
Comment on attachment 55651 [details]
Patch

Clearing flags on attachment: 55651

Committed r59340: <http://trac.webkit.org/changeset/59340>
Comment 6 WebKit Commit Bot 2010-05-12 21:12:35 PDT
All reviewed patches have been landed.  Closing bug.