Bug 38873 - [V8] Fix V8 code generator script to generate the correct code for converting ScriptString
Summary: [V8] Fix V8 code generator script to generate the correct code for converting...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jian Li
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 15:41 PDT by Jian Li
Modified: 2010-05-10 16:39 PDT (History)
1 user (show)

See Also:


Attachments
Proposed Patch (3.44 KB, patch)
2010-05-10 15:46 PDT, Jian Li
abarth: review+
jianli: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2010-05-10 15:41:34 PDT
This is caused by r58921 which I introduced the wrong V8 generator code.
Comment 1 Jian Li 2010-05-10 15:46:47 PDT
Created attachment 55613 [details]
Proposed Patch
Comment 2 Adam Barth 2010-05-10 15:51:16 PDT
Comment on attachment 55613 [details]
Proposed Patch

WebCore/bindings/scripts/CodeGeneratorV8.pm: 
 +          return "v8StringOrNull(exec, $value)" if $conv;
Oh, sorry.  I should have caught that in review.  :(
Comment 3 Jian Li 2010-05-10 16:39:06 PDT
Committed as http://trac.webkit.org/changeset/59104.