Bug 38869 - [Chromium] Chromium's SQLite VFS implementation on Linux doesn't need a dir fd
Summary: [Chromium] Chromium's SQLite VFS implementation on Linux doesn't need a dir fd
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Dumitru Daniliuc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 14:49 PDT by Dumitru Daniliuc
Modified: 2010-05-12 14:52 PDT (History)
2 users (show)

See Also:


Attachments
patch (5.66 KB, patch)
2010-05-10 19:31 PDT, Dumitru Daniliuc
dglazkov: review+
dumi: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2010-05-10 14:49:29 PDT
SQLite's default VFS implementation on POSIX systems stores the file descriptor of the directory where all DB files are stored. SQLite uses dirfd to sync the DB files if it is compiled with -DSQLITE_NO_SYNC. Chromium compiles its SQLite library without -DSQLITE_NO_SYNC. Therefore, storing the dirfd is unnecessary and can actually be a security problem. We should clean up that code.
Comment 1 Dumitru Daniliuc 2010-05-10 19:31:10 PDT
Created attachment 55647 [details]
patch
Comment 2 Dimitri Glazkov (Google) 2010-05-12 13:46:06 PDT
Comment on attachment 55647 [details]
patch

ok.
Comment 3 Dumitru Daniliuc 2010-05-12 14:52:49 PDT
Landed as r59273.