Bug 38866 - webkit-patch upload --fancy-review now uses the bugzilla bug ID as the rietveld ID
Summary: webkit-patch upload --fancy-review now uses the bugzilla bug ID as the rietve...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 14:12 PDT by Ojan Vafai
Modified: 2010-05-12 16:55 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.45 KB, patch)
2010-05-10 14:16 PDT, Ojan Vafai
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-05-10 14:12:50 PDT
webkit-patch upload --fancy-review now uses the bugzilla bug ID as the rietveld ID
Comment 1 Ojan Vafai 2010-05-10 14:16:25 PDT
Created attachment 55602 [details]
Patch
Comment 2 Ojan Vafai 2010-05-10 14:20:06 PDT
Julie is changing bugzilla to have a has_rietveld flag and to use the bugzilla ID as the rietveld issue ID. Once we have that, I'll update the upload script to set that bit on the uploaded attachment as well.

Then all we'll need to get this all working is a bot that polls new patches and uploads them to rietveld.
Comment 3 Adam Barth 2010-05-12 15:20:47 PDT
Comment on attachment 55602 [details]
Patch

LGTM.  I like this design better.
Comment 4 Ojan Vafai 2010-05-12 16:55:40 PDT
Committed r59284: <http://trac.webkit.org/changeset/59284>