Bug 38863 - [Qt] Detect debug mode consistently
Summary: [Qt] Detect debug mode consistently
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Keywords: Qt
Depends on:
Blocks: 35784
  Show dependency treegraph
Reported: 2010-05-10 12:56 PDT by Laszlo Gombos
Modified: 2010-05-14 01:48 PDT (History)
5 users (show)

See Also:

use the CONFIG(release, debug|release) test everywhere (4.83 KB, patch)
2010-05-10 13:01 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-05-10 12:56:19 PDT
CONFIG(debug, debug|release) is not the same as !CONFIG(release, debug|release). This subtly difference only has impact in a few build environments. This difference has caused some hard to find build-breaks on Symbian.

The proposal is to use only either CONFIG(release, debug|release) or CONFIG(debug, debug|release) conditions everywhere but do not mix them.
Comment 1 Laszlo Gombos 2010-05-10 13:01:34 PDT
Created attachment 55595 [details]
use the CONFIG(release, debug|release) test everywhere
Comment 2 Csaba Osztrogonác 2010-05-12 13:59:04 PDT
Landed: http://trac.webkit.org/changeset/59264
Comment 3 Simon Hausmann 2010-05-14 01:42:52 PDT
<cherry-pick-for-backport: r59264>
Comment 4 Simon Hausmann 2010-05-14 01:48:01 PDT
Revision r59264 cherry-picked into qtwebkit-2.0 with commit 4ee9c252c187832cec8bf0b82e89e6016aec5388