Bug 38861 - new-run-webkit-tests fails when run under sys.platform == "windows" due to undefined signal.SIGKILL
Summary: new-run-webkit-tests fails when run under sys.platform == "windows" due to un...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 12:39 PDT by Eric Seidel (no email)
Modified: 2010-05-10 12:47 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.96 KB, patch)
2010-05-10 12:41 PDT, Eric Seidel (no email)
abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-05-10 12:39:20 PDT
new-run-webkit-tests fails when run under sys.platform == "windows" due to undefined signal.SIGKILL
Comment 1 Eric Seidel (no email) 2010-05-10 12:41:12 PDT
Created attachment 55591 [details]
Patch
Comment 2 Adam Barth 2010-05-10 12:43:10 PDT
Comment on attachment 55591 [details]
Patch

Ok, but you need to make these comments compile.  :)

WebKitTools/Scripts/webkitpy/common/system/executive_unittest.py:79
 +          # Note: Can't use a ternary since signal.SIGKILL is undefined for platform.sys == "windows"
What is platform.sys ?
Comment 3 Eric Seidel (no email) 2010-05-10 12:43:35 PDT
Traceback (most recent call last):
 File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\new-run-webkit-tests",
line 33, in <module>
   import webkitpy.layout_tests.run_webkit_tests as run_webkit_tests
 File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py",
line 77, in <module>
   from webkitpy.common.system.executive import Executive
 File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\common\system\executive.py",
line 93, in <module>
   class Executive(object):
 File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\common\system\executive.py",
line 174, in Executive
   _KILL_PROCESS_KILLED_PROCESS_EXIT_CODE = 0 if sys.platform ==
"windows" else -signal.SIGKILL
AttributeError: 'module' object has no attribute 'SIGKILL'

Was the exception.

I've not tested this code on sys.platform == "windows" as I don't currently have such a setup.  We need to get the chromium canary bots to run test-webkitpy.
Comment 4 Eric Seidel (no email) 2010-05-10 12:44:35 PDT
Oops.  Fixed to sys.platform in comment.  Thanks.
Comment 5 Eric Seidel (no email) 2010-05-10 12:47:48 PDT
Committed r59090: <http://trac.webkit.org/changeset/59090>