Bug 38861 – new-run-webkit-tests fails when run under sys.platform == "windows" due to undefined signal.SIGKILL

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

new-run-webkit-tests fails when run under sys.platform == "windows" due to undefined signal.SIGKILL

[Eric Seidel (no email)]

Created attachment 55591 [details]
Patch

[Adam Barth]

Comment on attachment 55591 [details]
Patch

Ok, but you need to make these comments compile.  :)

WebKitTools/Scripts/webkitpy/common/system/executive_unittest.py:79
 +          # Note: Can't use a ternary since signal.SIGKILL is undefined for platform.sys == "windows"
What is platform.sys ?

[Eric Seidel (no email)]

Traceback (most recent call last):
 File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\new-run-webkit-tests",
line 33, in <module>
   import webkitpy.layout_tests.run_webkit_tests as run_webkit_tests
 File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py",
line 77, in <module>
   from webkitpy.common.system.executive import Executive
 File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\common\system\executive.py",
line 93, in <module>
   class Executive(object):
 File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\common\system\executive.py",
line 174, in Executive
   _KILL_PROCESS_KILLED_PROCESS_EXIT_CODE = 0 if sys.platform ==
"windows" else -signal.SIGKILL
AttributeError: 'module' object has no attribute 'SIGKILL'

Was the exception.

I've not tested this code on sys.platform == "windows" as I don't currently have such a setup.  We need to get the chromium canary bots to run test-webkitpy.

[Eric Seidel (no email)]

Oops.  Fixed to sys.platform in comment.  Thanks.

[Eric Seidel (no email)]

Committed r59090: <http://trac.webkit.org/changeset/59090>