Bug 38859 - [Qt]Unskip security/set-form-autocomplete-attribute.html
Summary: [Qt]Unskip security/set-form-autocomplete-attribute.html
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Robert Hogan
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-05-10 11:29 PDT by Robert Hogan
Modified: 2010-05-16 02:12 PDT (History)
1 user (show)

See Also:


Attachments
Patch (7.00 KB, patch)
2010-05-10 11:36 PDT, Robert Hogan
kenneth: review+
kenneth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2010-05-10 11:29:30 PDT
Add support for layoutTestController.elementDoesAutoCompleteForElementWithId().
Comment 1 Robert Hogan 2010-05-10 11:36:30 PDT
Created attachment 55580 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2010-05-13 11:35:49 PDT
Comment on attachment 55580 [details]
Patch

WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:425
 +  bool DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId(QWebFrame *frame, const QString &elementId)
Coding style issue :-) watch the placement of the * & etc

WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:81
 +      static bool elementDoesAutoCompleteForElementWithId(QWebFrame *frame, const QString &elementId);
Here as well

Please fix before landing.
Comment 3 Robert Hogan 2010-05-16 02:11:46 PDT
Landed as r59573. Closing.