RESOLVED WONTFIX 38855
check-webkit-style issue with lower/upper case 
https://bugs.webkit.org/show_bug.cgi?id=38855
Summary check-webkit-style issue with lower/upper case
John Abd-El-Malek
Reported 2010-05-10 10:08:56 PDT
I got a warning for this #include "Scrollbar.h" #include "ScrollbarTheme.h" #include "ScrollTypes.h" But I believe this is ordered correctly, and the problem is because it thinks "T" is before "b" because of the ASCII representation.
Attachments
Patch (2.97 KB, patch)
2013-03-12 18:23 PDT, Alan Cutter 		levin: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alan Cutter
Comment 1 2013-03-12 18:23:36 PDT
Created attachment 192849 [details] Patch
David Levin
Comment 2 2013-03-12 19:09:37 PDT
Comment on attachment 192849 [details] Patch The bug wasn't filed by someone familiar with WebKit style: Other #include statements should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command). Don't bother to organize them in a logical order. -- http://www.webkit.org/coding/coding-style.html
Alan Cutter
Comment 3 2013-03-12 19:17:13 PDT
(In reply to comment #2) > (From update of attachment 192849 [details]) > The bug wasn't filed by someone familiar with WebKit style: > > Other #include statements should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command). Don't bother to organize them in a logical order. > -- http://www.webkit.org/coding/coding-style.html Thanks for clarifying, closing bug.
Note You need to log in before you can comment on or make changes to this bug.