Bug 38855 - check-webkit-style issue with lower/upper case
Summary: check-webkit-style issue with lower/upper case
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Alan Cutter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 10:08 PDT by John Abd-El-Malek
Modified: 2013-03-12 19:17 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.97 KB, patch)
2013-03-12 18:23 PDT, Alan Cutter 		levin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Abd-El-Malek 2010-05-10 10:08:56 PDT 
I got a warning for this

#include "Scrollbar.h"
#include "ScrollbarTheme.h"
#include "ScrollTypes.h"

But I believe this is ordered correctly, and the problem is because it thinks "T" is before "b" because of the ASCII representation.
Comment 1 Alan Cutter 2013-03-12 18:23:36 PDT 
Created attachment 192849 [details]
Patch
Comment 2 David Levin 2013-03-12 19:09:37 PDT 
Comment on attachment 192849 [details]
Patch

The bug wasn't filed by someone familiar with WebKit style:

Other #include statements should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command). Don't bother to organize them in a logical order.
-- http://www.webkit.org/coding/coding-style.html
Comment 3 Alan Cutter 2013-03-12 19:17:13 PDT 
(In reply to comment #2)
> (From update of attachment 192849 [details])
> The bug wasn't filed by someone familiar with WebKit style:
> 
> Other #include statements should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command). Don't bother to organize them in a logical order.
> -- http://www.webkit.org/coding/coding-style.html

Thanks for clarifying, closing bug.