Bug 38846 - Merge some pseudo-valid-*.html tests into one
Summary: Merge some pseudo-valid-*.html tests into one
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 08:28 PDT by Kent Tamura
Modified: 2010-05-11 09:15 PDT (History)
1 user (show)

See Also:


Attachments
Patch (10.59 KB, patch)
2010-05-10 08:36 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-05-10 08:28:48 PDT
Merge some pseudo-valid-*.html tests into one
Comment 1 Kent Tamura 2010-05-10 08:32:44 PDT
I'm going to add test cases for pseudo :valid.  Before that, I'd like to merge and rename existing tests.
Comment 2 Kent Tamura 2010-05-10 08:36:39 PDT
Created attachment 55556 [details]
Patch
Comment 3 Kent Tamura 2010-05-10 22:36:14 PDT
Hamaji-san, could you review this?
Comment 4 Shinichiro Hamaji 2010-05-10 22:49:01 PDT
Comment on attachment 55556 [details]
Patch

> +var notValidColor = "rgb(0, 255, 0)";
> +for (var i = 0; i < names.length; i++)
> +    shouldBe("getBackgroundColor('" + names[i] + "')", "notValidColor");

I slightly prefer rgb(0, 255, 0) to notValidColor because "foobar is not valid color" sounds like this test is failing.

    shouldBe("getBackgroundColor('" + names[i] + "')", "rgb(0, 255, 0)");

Also, I think the color should be not valid nor invalid, right?
Comment 5 Kent Tamura 2010-05-10 22:56:59 PDT
Thank you for reviewing!

(In reply to comment #4)
> (From update of attachment 55556 [details])
> > +var notValidColor = "rgb(0, 255, 0)";
> > +for (var i = 0; i < names.length; i++)
> > +    shouldBe("getBackgroundColor('" + names[i] + "')", "notValidColor");
> 
> I slightly prefer rgb(0, 255, 0) to notValidColor because "foobar is not valid color" sounds like this test is failing.

I see.  It might be confusing.  ok, I'll change notValidColor before landing this.

>     shouldBe("getBackgroundColor('" + names[i] + "')", "rgb(0, 255, 0)");
> 
> Also, I think the color should be not valid nor invalid, right?

You're right.
Comment 6 Kent Tamura 2010-05-11 09:15:05 PDT
Landed as r59153