Merge some pseudo-valid-*.html tests into one
I'm going to add test cases for pseudo :valid. Before that, I'd like to merge and rename existing tests.
Created attachment 55556 [details] Patch
Hamaji-san, could you review this?
Comment on attachment 55556 [details] Patch > +var notValidColor = "rgb(0, 255, 0)"; > +for (var i = 0; i < names.length; i++) > + shouldBe("getBackgroundColor('" + names[i] + "')", "notValidColor"); I slightly prefer rgb(0, 255, 0) to notValidColor because "foobar is not valid color" sounds like this test is failing. shouldBe("getBackgroundColor('" + names[i] + "')", "rgb(0, 255, 0)"); Also, I think the color should be not valid nor invalid, right?
Thank you for reviewing! (In reply to comment #4) > (From update of attachment 55556 [details]) > > +var notValidColor = "rgb(0, 255, 0)"; > > +for (var i = 0; i < names.length; i++) > > + shouldBe("getBackgroundColor('" + names[i] + "')", "notValidColor"); > > I slightly prefer rgb(0, 255, 0) to notValidColor because "foobar is not valid color" sounds like this test is failing. I see. It might be confusing. ok, I'll change notValidColor before landing this. > shouldBe("getBackgroundColor('" + names[i] + "')", "rgb(0, 255, 0)"); > > Also, I think the color should be not valid nor invalid, right? You're right.
Landed as r59153