Bug 38838 - RenderSVGImage::imageChanged should invalidate the SVG filter cache
Summary: RenderSVGImage::imageChanged should invalidate the SVG filter cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 03:13 PDT by Zoltan Herczeg
Modified: 2010-05-11 08:27 PDT (History)
2 users (show)

See Also:


Attachments
patch (11.40 KB, patch)
2010-05-10 03:19 PDT, Zoltan Herczeg
no flags Details | Formatted Diff | Diff
patch (11.40 KB, patch)
2010-05-10 03:32 PDT, Zoltan Herczeg
krit: review-
krit: commit-queue-
Details | Formatted Diff | Diff
patch + more description (11.77 KB, patch)
2010-05-10 05:04 PDT, Zoltan Herczeg
krit: review+
krit: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Herczeg 2010-05-10 03:13:58 PDT
Otherwise, the nullImage is cached, and no update after the resource arrived.
Comment 1 Zoltan Herczeg 2010-05-10 03:19:31 PDT
Created attachment 55535 [details]
patch
Comment 2 WebKit Review Bot 2010-05-10 03:25:05 PDT
Attachment 55535 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/RenderSVGImage.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zoltan Herczeg 2010-05-10 03:32:23 PDT
Created attachment 55538 [details]
patch
Comment 4 Dirk Schulze 2010-05-10 04:16:56 PDT
Comment on attachment 55538 [details]
patch

Your patch looks good. But you should realy write more into the ChangeLog. What is the exactproblem, how and where did you solve this. And so on...

r- mainly because of missing informations in the Changelog
Comment 5 Zoltan Herczeg 2010-05-10 05:04:00 PDT
Created attachment 55544 [details]
patch + more description
Comment 6 Dirk Schulze 2010-05-10 05:18:01 PDT
Comment on attachment 55544 [details]
patch + more description

Great. Looks good now. Sadly we can't upload this patch as is, because of DRT changes. That means you need to update your DRT result for the test.
I still r+ this patch because you have commiting rights and can update and upload the patch yourself. Otherwise post a new patch.
Comment 7 Zoltan Herczeg 2010-05-11 08:27:33 PDT
Landed in r59147. http://trac.webkit.org/changeset/59147

Closing bug.