REGRESSION(r57955): RegExp literals should not actually be cached, so r57955 should be rolled out.
Created attachment 55513 [details]
Comment on attachment 55513 [details]
This patch does not give the reason they should not be cached. Is it because caching them makes things slower? Or perhaps it gives incorrect results?
In order to match firefox I made JSC cache regexp literals, however it turns out that this behaviour is part of ES3, and ES5 mandates the we don't cache. eg. Old JSC was correct per-ES5. This needs to be reverted due to the following reasons:
1. We did this partially as a compat fix, but firefox is dropping regexp caching in 3.7 and moving to our (old) non-caching behaviour. eg. we will be the only browser that does this.
2. Even in firefox, where regexp literals have always been cached, the caching of regexp literals is their 2nd most frequently duped bug report.
3. Due to the way RegExp.lastIndex works this change in behaviour can result in significantly different regexp behaviour.
Attachment 55513 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
Total errors found: 2 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r59064: <http://trac.webkit.org/changeset/59064>