Bug 38825 – HTMLInputElement::size not available through Chromium WebInputElement interface

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[David Holloway]

The Chromium WebInputElement interface does not provide an accessor to HTMLInputElement::size().  During form AutoFill Chromium needs to access the input element's size attribute in aid of form matching and filling heuristics.

Files in question:
  WebKit/chromium/public/WebInputElement.h
  WebKit/chromium/src/WebInputElement.cpp

Expected:
  WebKit::WebInputElement::size() method should exist and provide value of HTMLInputElement::siz().

[David Holloway]

Created attachment 55512 [details]
Patch

[David Holloway]

Created attachment 55574 [details]
Rewording in change log.

Rewording in change log.

[WebKit Review Bot]

Attachment 55574 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
WebKit/chromium/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Fisher (:fishd, Google)]

Comment on attachment 55574 [details]
Rewording in change log.

WebKit/chromium/ChangeLog:7
 +  		access the input element's size attribute in aid of form matching and
replace tabs with spaces.

otherwise LGTM

[David Holloway]

Created attachment 55592 [details]
Removed tabs.

Removed tabs.

[WebKit Commit Bot]

Comment on attachment 55592 [details]
Removed tabs.

Clearing flags on attachment: 55592

Committed r59176: <http://trac.webkit.org/changeset/59176>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.