Bug 38825 - HTMLInputElement::size not available through Chromium WebInputElement interface
Summary: HTMLInputElement::size not available through Chromium WebInputElement interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-09 17:12 PDT by David Holloway
Modified: 2010-05-11 15:39 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2010-05-09 17:20 PDT, David Holloway 		no flags Details | Formatted Diff | Diff
Rewording in change log. (1.96 KB, patch)
2010-05-10 11:00 PDT, David Holloway 		fishd: review-
Details | Formatted Diff | Diff
Removed tabs. (1.97 KB, patch)
2010-05-10 12:51 PDT, David Holloway 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Holloway 2010-05-09 17:12:05 PDT 
The Chromium WebInputElement interface does not provide an accessor to HTMLInputElement::size().  During form AutoFill Chromium needs to access the input element's size attribute in aid of form matching and filling heuristics.

Files in question:
  WebKit/chromium/public/WebInputElement.h
  WebKit/chromium/src/WebInputElement.cpp

Expected:
  WebKit::WebInputElement::size() method should exist and provide value of HTMLInputElement::siz().
Comment 1 David Holloway 2010-05-09 17:20:05 PDT 
Created attachment 55512 [details]
Patch
Comment 2 David Holloway 2010-05-10 11:00:29 PDT 
Created attachment 55574 [details]
Rewording in change log.

Rewording in change log.
Comment 3 WebKit Review Bot 2010-05-10 11:07:27 PDT 
Attachment 55574 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
WebKit/chromium/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Darin Fisher (:fishd, Google) 2010-05-10 12:19:15 PDT 
Comment on attachment 55574 [details]
Rewording in change log.

WebKit/chromium/ChangeLog:7
 +  		access the input element's size attribute in aid of form matching and
replace tabs with spaces.

otherwise LGTM
Comment 5 David Holloway 2010-05-10 12:51:17 PDT 
Created attachment 55592 [details]
Removed tabs.

Removed tabs.
Comment 6 WebKit Commit Bot 2010-05-11 15:39:32 PDT 
Comment on attachment 55592 [details]
Removed tabs.

Clearing flags on attachment: 55592

Committed r59176: <http://trac.webkit.org/changeset/59176>
Comment 7 WebKit Commit Bot 2010-05-11 15:39:38 PDT 
All reviewed patches have been landed.  Closing bug.