Bug 38821 - Calling Node::setDocument() to change the document has no effect
Summary: Calling Node::setDocument() to change the document has no effect
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
Depends on:
Reported: 2010-05-09 15:17 PDT by Chris Jerdonek
Modified: 2010-05-10 05:00 PDT (History)
4 users (show)

See Also:

Proposed patch (1.76 KB, patch)
2010-05-09 16:54 PDT, Chris Jerdonek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-05-09 15:17:19 PDT
Node::setDocument() does nothing if the caller attempts to change the document of a node using it.

To avoid the mistake of trying to use setDocument() to change the document of a node (without first removing the node from its document), we may want to assert at the beginning that the caller is not attempting to do this.
Comment 1 Chris Jerdonek 2010-05-09 16:54:15 PDT
Created attachment 55511 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2010-05-10 04:41:05 PDT
Comment on attachment 55511 [details]
Proposed patch

Clearing flags on attachment: 55511

Committed r59072: <http://trac.webkit.org/changeset/59072>
Comment 3 WebKit Commit Bot 2010-05-10 04:41:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2010-05-10 05:00:54 PDT
http://trac.webkit.org/changeset/59072 might have broken Qt Linux ARMv5 Release