Bug 38776 - [chromium] Remove temporary relative include paths
Summary: [chromium] Remove temporary relative include paths
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-07 14:36 PDT by Darin Fisher (:fishd, Google)
Modified: 2010-05-14 23:51 PDT (History)
1 user (show)

See Also:

Attachments
v1 patch (11.87 KB, patch)
2010-05-07 14:38 PDT, Darin Fisher (:fishd, Google) 		no flags Details | Formatted Diff | Diff
v2 patch (make the style bot happy) (12.02 KB, patch)
2010-05-07 16:21 PDT, Darin Fisher (:fishd, Google) 		dglazkov: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2010-05-07 14:36:49 PDT 
[chromium] Remove temporary relative include paths
Comment 1 Darin Fisher (:fishd, Google) 2010-05-07 14:38:29 PDT 
Created attachment 55418 [details]
v1 patch

Note, there is some inconsistency style-wise with how we mix WebKit headers with WebCore headers.  I'm not attempting to unify style in this patch.
Comment 2 WebKit Review Bot 2010-05-07 14:42:01 PDT 
Attachment 55418 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/src/WebBindings.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/src/WebDataSourceImpl.h:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Fisher (:fishd, Google) 2010-05-07 15:57:19 PDT 
Those style issues are related to what I wrote in comment #1.  Please disregard them.  I will deal with that class of style issue later.
Comment 4 Darin Fisher (:fishd, Google) 2010-05-07 16:21:47 PDT 
Created attachment 55429 [details]
v2 patch (make the style bot happy)
Comment 5 Dimitri Glazkov (Google) 2010-05-07 16:22:58 PDT 
Comment on attachment 55429 [details]
v2 patch (make the style bot happy)

ok.
Comment 6 Darin Fisher (:fishd, Google) 2010-05-14 23:51:24 PDT 
Landed as http://trac.webkit.org/changeset/59524