Bug 38767 - RenderSVGResourceClipper assigns a temporary mutated RenderStyle but does not correctly preserve the old style
Summary: RenderSVGResourceClipper assigns a temporary mutated RenderStyle but does not...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-07 12:22 PDT by Nikolas Zimmermann
Modified: 2010-05-07 21:45 PDT (History)
4 users (show)

See Also:


Attachments
Patch (19.75 KB, patch)
2010-05-07 12:27 PDT, Nikolas Zimmermann
krit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-05-07 12:22:27 PDT
RenderSVGResourceClipper has side-effects, see on the windows bots. The results there are actually correct.
Uploading a fix soon.
Comment 1 Nikolas Zimmermann 2010-05-07 12:27:55 PDT
Created attachment 55406 [details]
Patch
Comment 2 Dirk Schulze 2010-05-07 12:31:55 PDT
Comment on attachment 55406 [details]
Patch

LGTM r=me
Comment 3 Nikolas Zimmermann 2010-05-07 12:36:31 PDT
Committed r58965: <http://trac.webkit.org/changeset/58965>
Comment 4 WebKit Review Bot 2010-05-07 13:28:58 PDT
http://trac.webkit.org/changeset/58965 might have broken Tiger Intel Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/58963
http://trac.webkit.org/changeset/58965
Comment 5 Dirk Schulze 2010-05-07 21:45:05 PDT
(In reply to comment #4)
> http://trac.webkit.org/changeset/58965 might have broken Tiger Intel Release
> The following changes are on the blame list:
> http://trac.webkit.org/changeset/58963
> http://trac.webkit.org/changeset/58965

None of the patch related tests fail. Not the patches fault :-)