Bug 38763 - ResourceHandleSoup should not depend on GTK+
Summary: ResourceHandleSoup should not depend on GTK+
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-07 11:46 PDT by Leandro Pereira
Modified: 2010-05-08 10:53 PDT (History)
1 user (show)

See Also:


Attachments
ResourceHandleSoup should not depend on GTK+ (4.22 KB, patch)
2010-05-07 11:47 PDT, Leandro Pereira
gns: review-
Details | Formatted Diff | Diff
ResourceHandleSoup should not depend on GTK+ (3.66 KB, patch)
2010-05-07 12:13 PDT, Leandro Pereira
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leandro Pereira 2010-05-07 11:46:39 PDT
ResourceHandleSoup.cpp includes gtk/gtk.h, while it should include only glib.h. Attached patches fixes that.
Comment 1 Leandro Pereira 2010-05-07 11:47:37 PDT
Created attachment 55401 [details]
ResourceHandleSoup should not depend on GTK+
Comment 2 Gustavo Noronha (kov) 2010-05-07 12:03:17 PDT
Comment on attachment 55401 [details]
ResourceHandleSoup should not depend on GTK+

Change the CString include to be #include "CString.h", please, and leave it at the first block.
Comment 3 Gustavo Noronha (kov) 2010-05-07 12:05:16 PDT
Comment on attachment 55401 [details]
ResourceHandleSoup should not depend on GTK+

461461     g_object_set(session,
462462                  SOUP_SESSION_MAX_CONNS, MAX_CONNECTIONS,
463463                  SOUP_SESSION_MAX_CONNS_PER_HOST, MAX_CONNECTIONS_PER_HOST,
464                   NULL);
 464                  0);

We use NULL for GObject calls, because they generate compiler warnings otherwise.

596      // Used to set the authentication dialog toplevel; may be NULL
 596     // Used to set the authentication dialog toplevel; may be 0

This is a bug in the checker, just leave this as NULL.
Comment 4 Leandro Pereira 2010-05-07 12:13:15 PDT
Created attachment 55403 [details]
ResourceHandleSoup should not depend on GTK+

Reviewed patch according to gns' comments.
Comment 5 Gustavo Noronha (kov) 2010-05-07 12:47:08 PDT
Comment on attachment 55403 [details]
ResourceHandleSoup should not depend on GTK+

Looks good!
Comment 6 WebKit Commit Bot 2010-05-08 10:53:51 PDT
Comment on attachment 55403 [details]
ResourceHandleSoup should not depend on GTK+

Clearing flags on attachment: 55403

Committed r59028: <http://trac.webkit.org/changeset/59028>
Comment 7 WebKit Commit Bot 2010-05-08 10:53:56 PDT
All reviewed patches have been landed.  Closing bug.