RESOLVED FIXED 38755
Web Inspector: come up with InjectedScript._className that works for both JSC and V8. 
https://bugs.webkit.org/show_bug.cgi?id=38755
Summary Web Inspector: come up with InjectedScript._className that works for both JSC...
Pavel Feldman
Reported 2010-05-07 09:28:24 PDT
There is a conceptual difference between the engines: JSC: typeof Document === "object" V8: typeof Document === "function" As a result, getting the class names using same code is challenging. I gave up and made a fork.
Attachments
[PATCH] Proposed fix. (1.73 KB, patch)
2010-05-07 09:36 PDT, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-05-07 09:36:10 PDT
Created attachment 55385 [details] [PATCH] Proposed fix.
Timothy Hatcher
Comment 2 2010-05-07 09:41:56 PDT
Comment on attachment 55385 [details] [PATCH] Proposed fix. Should we file a bug with V8 or JSC?
Pavel Feldman
Comment 3 2010-05-07 09:44:35 PDT
(In reply to comment #2) > (From update of attachment 55385 [details]) > Should we file a bug with V8 or JSC? I am afraid teams are not interested in fixing it one way or the other - we are the only clients suffering so far. I'll follow up with the V8 folks locally.
Pavel Feldman
Comment 4 2010-05-07 09:59:49 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/InjectedScript.js Committed r58953
Note You need to log in before you can comment on or make changes to this bug.