Bug 38750 – [Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Hans Wennborg]

[Chromium] StorageNamespaceProxy should pass quota argument for SessionStorage

[Hans Wennborg]

Created attachment 55377 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 55377 [details]
Patch

Never in this bug or ChangeLog is there any explanation of "why".

[Jeremy Orlow]

Comment on attachment 55377 [details]
Patch

Didn't you mean to commit-queue+ this?


> diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
> index 039cd6c8cf40225242ab5e344228330c25ff298a..f524215c85002614593e2d1f2bc09fa3bef93f91 100644
> --- a/WebKit/chromium/ChangeLog
> +++ b/WebKit/chromium/ChangeLog
> @@ -1,3 +1,16 @@
> [phone]  Hans Wennborg  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Chromium] StorageNamespaceProxy should pass quota argument for SessionStorage
> +        https://bugs.webkit.org/show_bug.cgi?id=38750

Please explain why you're doing this and maybe a high level of what you're doing.

> +
> +        * public/WebStorageNamespace.h:
> +        * public/WebViewClient.h:
> +        (WebKit::WebViewClient::createSessionStorageNamespace):
> +        * src/StorageNamespaceProxy.cpp:
> +        (WebCore::StorageNamespace::sessionStorageNamespace):
> +
>  2010-05-06  Pavel Feldman  <[e-mail]>
>  
>          Reviewed by Timothy Hatcher.
> diff --git a/WebKit/chromium/public/WebStorageNamespace.h b/WebKit/chromium/public/WebStorageNamespace.h
> index 4b648d43a63622dd5b149af588715879ee1f403a..df9feaaeee11a6e89391d7287de5214ae49aef8e 100644
> --- a/WebKit/chromium/public/WebStorageNamespace.h
> +++ b/WebKit/chromium/public/WebStorageNamespace.h
> @@ -49,11 +49,22 @@ public:
>      // object when you're finished.
>      WEBKIT_API static WebStorageNamespace* createLocalStorageNamespace(const WebString& backingDirectoryPath, unsigned quota);
>      WEBKIT_API static WebStorageNamespace* createSessionStorageNamespace(unsigned quota);
> +
> +    // FIXME(hans) Remove this when Chromium is rolled and all callers pass

// FIXME:Remove this ....

> +    // the quota argument.

Don't line wrap.

>      WEBKIT_API static WebStorageNamespace* createSessionStorageNamespace()
>      {
>          return createSessionStorageNamespace(noQuota);
>      }
>  
> +    // The quota for each storage area.  Suggested by the spec.
> +    static const unsigned m_localStorageQuota = 5 * 1024 * 1024;
> +
> +    // Since SessionStorage memory is allocated in the browser process, we place a
> +    // per-origin quota on it.  Like LocalStorage there are known attacks against
> +    // this, so it's more of a sanity check than a real security measure.
> +    static const unsigned m_sessionStorageQuota = 5 * 1024 * 1024;
> +
>      static const unsigned noQuota = UINT_MAX;
>  
>      virtual ~WebStorageNamespace() { }
> diff --git a/WebKit/chromium/public/WebViewClient.h b/WebKit/chromium/public/WebViewClient.h
> index 98e048593658f8bb97d8ed48a604f6cf3ad98679..749f559061430c67608f307aa0ade250c6ace6d1 100644
> --- a/WebKit/chromium/public/WebViewClient.h
> +++ b/WebKit/chromium/public/WebViewClient.h
> @@ -81,6 +81,10 @@ public:
>      virtual WebWidget* createPopupMenu(const WebPopupMenuInfo&) { return 0; }
>  
>      // Create a session storage namespace object associated with this WebView.
> +
> +    // FIXME(hans) This is needed while subclasses implement the method without

ditto

> +    // the quota parameter but callers inside WebKit pass a quota argument.

ditto

[Hans Wennborg]

Created attachment 55531 [details]
Patch

[Jeremy Orlow]

Comment on attachment 55531 [details]
Patch

> diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
> index 8a25606961ee8b3995a77c5a97e7bedcb9135890..5d13f4d8b182fd1ae743f5c3c0548e1414c47a4a 100644
> --- a/WebKit/chromium/ChangeLog
> +++ b/WebKit/chromium/ChangeLog
> @@ -1,3 +1,21 @@
> [phone]  Hans Wennborg  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()
> +
> +        Put a per-origin quota on session storage since it is using memory in
> +        the browser process, and should not be allowed to grow arbitrarily
> +        large. See also r58828.

Links to trac.webkit.org are probably better than just saying rXXXXX.

> +        https://bugs.webkit.org/show_bug.cgi?id=38750

This goes directly below the subject line...then a blank newline...then the full description.


Same goes for the other change log.

Otherwise, looks good.  Please fix and re-upload with commit queue bit since you can't commit yet.

[Hans Wennborg]

Created attachment 55532 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 55532 [details]
Patch

Clearing flags on attachment: 55532

Committed r59077: <http://trac.webkit.org/changeset/59077>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.