Bug 38746 - [GTK] Fails to build on GTK+ < 2.14
Summary: [GTK] Fails to build on GTK+ < 2.14
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2010-05-07 06:53 PDT by Gustavo Noronha (kov)
Modified: 2010-05-07 07:14 PDT (History)
3 users (show)

See Also:


Attachments
proposed fix (2.22 KB, patch)
2010-05-07 06:55 PDT, Gustavo Noronha (kov)
gustavo: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2010-05-07 06:53:40 PDT
Because we are now using gtk_adjustment_configure.
Comment 1 Gustavo Noronha (kov) 2010-05-07 06:55:08 PDT
Created attachment 55370 [details]
proposed fix
Comment 2 WebKit Review Bot 2010-05-07 06:56:04 PDT
Attachment 55370 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/gtk/ScrollViewGtk.cpp:78:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/platform/gtk/ScrollViewGtk.cpp:89:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/gtk/ScrollViewGtk.cpp:94:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gustavo Noronha (kov) 2010-05-07 06:58:54 PDT
Comment on attachment 55370 [details]
proposed fix

I'll commit manually with style fixed.
Comment 4 Gustavo Noronha (kov) 2010-05-07 07:14:42 PDT
Comment on attachment 55370 [details]
proposed fix

Landed as  58946 with rs by kenne.