Bug 38741 - Fix halfword loads on ARM
Summary: Fix halfword loads on ARM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-07 05:06 PDT by Gabor Loki
Modified: 2010-05-12 03:51 PDT (History)
4 users (show)

See Also:


Attachments
Fix halfword loads on ARM (3.75 KB, patch)
2010-05-07 05:07 PDT, Gabor Loki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2010-05-07 05:06:04 PDT
The BaseIndex and ImplicitAddress are contain 32bit wide offset, but the load16 functions were working with 8 bit data (encoded in the instruction). If the offset cannot be encoded in an instruction, it should be stored in a temporary register.
Comment 1 Gabor Loki 2010-05-07 05:07:16 PDT
Created attachment 55363 [details]
Fix halfword loads on ARM
Comment 2 WebKit Commit Bot 2010-05-08 13:03:40 PDT
Comment on attachment 55363 [details]
Fix halfword loads on ARM

Clearing flags on attachment: 55363

Committed r59038: <http://trac.webkit.org/changeset/59038>
Comment 3 WebKit Commit Bot 2010-05-08 13:03:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Simon Hausmann 2010-05-12 03:41:04 PDT
Laszlo, this patch doesn't apply at all in the branch. There's no load16() function in MacroAssembler ARM. Is the branch affected by this issue at all?

(Removing from the blocker list until we have something to cherry-pick :)
Comment 5 Gabor Loki 2010-05-12 03:51:26 PDT
This patch fixed both load16 functions. The load16(ImplicitAddress) is a newer function. I guess this one is missing from the Qt branch. You can add the load16(ImplicitAddress) function as well or inline its body into the load16(BaseIndex) function.