Bug 38740 - Web Inspector: On Linux/Windows panel history is traversed while iterating over words in text prompt.
Summary: Web Inspector: On Linux/Windows panel history is traversed while iterating ov...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-07 04:42 PDT by Pavel Feldman
Modified: 2010-05-07 10:03 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed fix. (2.77 KB, patch)
2010-05-07 04:46 PDT, Pavel Feldman
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-05-07 04:42:06 PDT
Patch to follow.
Comment 1 Pavel Feldman 2010-05-07 04:46:21 PDT
Created attachment 55362 [details]
[PATCH] Proposed fix.
Comment 2 Joseph Pecoraro 2010-05-07 08:13:31 PDT
Comment on attachment 55362 [details]
[PATCH] Proposed fix.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index e498aa5..a279f5a 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,16 @@
> +2010-05-07  Pavel Feldman  <pfeldman@chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Web Inspector: On Linux/Windows panel history is traversed while iterating over words in text prompt.
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=38740
> +
> +        * inspector/front-end/TextPrompt.js:
> +        (WebInspector.TextPrompt):
> +        * inspector/front-end/inspector.js:
> +        (WebInspector.documentKeyDown):
> +

NIT: ChangeLog could include an explanation about why this didn't work.

Thanks for catching this.
Comment 3 Pavel Feldman 2010-05-07 10:03:38 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/TextPrompt.js
	M	WebCore/inspector/front-end/inspector.js
Committed r58954