Bug 38732 - Web Inspector: Cosmetic changes in Timeline Panel.
Summary: Web Inspector: Cosmetic changes in Timeline Panel.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
Depends on:
Reported: 2010-05-07 02:31 PDT by Ilya Tikhonovsky
Modified: 2010-05-10 09:17 PDT (History)
7 users (show)

See Also:

[patch] Initial version. (6.14 KB, patch)
2010-05-07 02:34 PDT, Ilya Tikhonovsky
pfeldman: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-05-07 02:31:41 PDT
1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child.
2) Standard tooltips for resource links are clashing with Popover.
3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows).
Comment 1 Ilya Tikhonovsky 2010-05-07 02:34:24 PDT
Created attachment 55351 [details]
[patch] Initial version.
Comment 2 WebKit Commit Bot 2010-05-08 05:11:37 PDT
Comment on attachment 55351 [details]
[patch] Initial version.

Rejecting patch 55351 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 18317 test cases.
inspector/timeline-event-dispatch.html -> failed

Exiting early after 1 failures. 14662 tests run.
265.54s total testing time

14661 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
7 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/2170072
Comment 3 Eric Seidel (no email) 2010-05-08 23:13:51 PDT
Attachment 55351 [details] was posted by a committer and has review+, assigning to Ilya Tikhonovsky for commit.
Comment 4 WebKit Review Bot 2010-05-09 14:56:37 PDT
http://trac.webkit.org/changeset/59062 might have broken GTK Linux 32-bit Release
Comment 5 Joseph Pecoraro 2010-05-09 15:03:28 PDT
Comment on attachment 55351 [details]
[patch] Initial version.

> +                console.log(WebInspector.linkifyResourceAsNode(record.data.url, "scripts", record.data.lineNumber, "", ""));

This looks like debug, it should not go in.

> +    else if (typeof tooltipText !== "string" || tooltipText.length != 0)

The second half of this should either be:

  tooltipText.length !== 0



Personally I'm a fan of the "!== 0" in cases of "length". But I don't think there is a style rule for this yet.
Comment 6 Ilya Tikhonovsky 2010-05-10 09:17:07 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/TimelinePanel.js
	M	WebCore/inspector/front-end/inspector.js
Committed r59080