Bug 38730 - [chromium] Build DRT when running build-webkit --chromium
Summary: [chromium] Build DRT when running build-webkit --chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-07 01:30 PDT by Tony Chang
Modified: 2010-05-10 20:48 PDT (History)
5 users (show)

See Also:


Attachments
Patch (19.11 KB, patch)
2010-05-07 01:33 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch (21.33 KB, patch)
2010-05-09 20:35 PDT, Tony Chang
tkent: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-05-07 01:30:37 PDT
[chromium] Build DRT when running build-webkit --chromium
Comment 1 Tony Chang 2010-05-07 01:33:36 PDT
Created attachment 55350 [details]
Patch
Comment 2 WebKit Review Bot 2010-05-07 01:41:24 PDT
Attachment 55350 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/2198037
Comment 3 Tony Chang 2010-05-09 20:35:46 PDT
Created attachment 55518 [details]
Patch
Comment 4 WebKit Review Bot 2010-05-09 20:41:16 PDT
Attachment 55518 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/2183099
Comment 5 Tony Chang 2010-05-09 23:24:46 PDT
(In reply to comment #4)
> Attachment 55518 [details] did not build on chromium:
> Build output: http://webkit-commit-queue.appspot.com/results/2183099

Is there a way for me to get the full build output?  It's not clear to me why the Chromium Linux build failed.  It looks like the Makefile didn't get regenerated properly.  I worked fine on my Linux desktop.
Comment 6 Adam Barth 2010-05-10 08:25:48 PDT
I think that is the full build output.  How did you process the gyp files?  The bot doesn't runhooks.  I think there's something in build-webkit that processes the gyp files.  Maybe that needs to be extended to process the drt gyp?
Comment 7 Tony Chang 2010-05-10 17:00:16 PDT
(In reply to comment #6)
> I think that is the full build output.  How did you process the gyp files?  The bot doesn't runhooks.  I think there's something in build-webkit that processes the gyp files.  Maybe that needs to be extended to process the drt gyp?

Yes, my change requires running gclient (since it changes DEPS).  Running update-webkit --chromium should do this, although it's probably easier to just run gclient sync in WebKit/WebKit/chromium.
Comment 8 Adam Barth 2010-05-10 17:14:23 PDT
Oh, I didn't notice the DEPS change.  The review bot doesn't understand DEPS.
Comment 9 Kent Tamura 2010-05-10 17:49:58 PDT
Comment on attachment 55518 [details]
Patch

WebKit/chromium/WebKit.gyp:445
 +                          # TODO(tony): Turn on warnings on other platforms and
nit: We don't use TODO(username) in WebKit.  This should be just FIXME.
Comment 10 Tony Chang 2010-05-10 20:48:00 PDT
Committed r59124: <http://trac.webkit.org/changeset/59124>