[chromium] Build DRT when running build-webkit --chromium
Created attachment 55350 [details] Patch
Attachment 55350 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2198037
Created attachment 55518 [details] Patch
Attachment 55518 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2183099
(In reply to comment #4) > Attachment 55518 [details] did not build on chromium: > Build output: http://webkit-commit-queue.appspot.com/results/2183099 Is there a way for me to get the full build output? It's not clear to me why the Chromium Linux build failed. It looks like the Makefile didn't get regenerated properly. I worked fine on my Linux desktop.
I think that is the full build output. How did you process the gyp files? The bot doesn't runhooks. I think there's something in build-webkit that processes the gyp files. Maybe that needs to be extended to process the drt gyp?
(In reply to comment #6) > I think that is the full build output. How did you process the gyp files? The bot doesn't runhooks. I think there's something in build-webkit that processes the gyp files. Maybe that needs to be extended to process the drt gyp? Yes, my change requires running gclient (since it changes DEPS). Running update-webkit --chromium should do this, although it's probably easier to just run gclient sync in WebKit/WebKit/chromium.
Oh, I didn't notice the DEPS change. The review bot doesn't understand DEPS.
Comment on attachment 55518 [details] Patch WebKit/chromium/WebKit.gyp:445 + # TODO(tony): Turn on warnings on other platforms and nit: We don't use TODO(username) in WebKit. This should be just FIXME.
Committed r59124: <http://trac.webkit.org/changeset/59124>