Bug 38725 – REGRESSION(r58936): "Broke a layout test on leopard" (Requested by eseidel on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/58936 broke the build:
"Broke a layout test on leopard" (Requested by eseidel on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 55340 [details]
ROLLOUT of r58936

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

[Eric Seidel (no email)]

Comment on attachment 55340 [details]
ROLLOUT of r58936

Looks like Simon's off for the night.  So lets roll this out and he an easily re-land in the morning with Leopard fixed.

Simon, obviously feel free to cancel the rollout if you're around and looking at this.

r58936 didn’t break a layout test. The layout test that was added in that
revision is failing on Leopard. It either needs platform-specific results or to
be skipped. There is no reason to undo the bugfix.

<http://trac.webkit.org/projects/webkit/changeset/58938>

[Eric Seidel (no email)]

Thank you mitz for the followup.