This report is to address the FIXME to use "not set" rather than "undef" in the various hash objects returned by the parse() methods.
Created attachment 55373 [details] Proposed patch
Comment on attachment 55373 [details] Proposed patch > @@ -456,7 +457,7 @@ sub parseGitDiffHeader($$) > > my $copiedFromPath; > my $foundHeaderEnding; > - my $isBinary; > + my $isBinary = 0; From my understanding, we can leave this as "my $isBinary;" based on your usage in: $header{isBinary} = $isBinary if $isBinary; > @@ -550,7 +552,7 @@ sub parseSvnDiffHeader($$) > my $copiedFromPath; > my $foundHeaderEnding; > my $indexPath; > - my $isBinary; > + my $isBinary = 0; Similarly, we can leave this as "my $isBinary;"; > @@ -640,8 +642,8 @@ sub parseDiffHeader($$) > my ($fileHandle, $line) = @_; > > my $header; # This is a hash ref. > - my $isGit; > - my $isSvn; > + my $isGit = 0; > + my $isSvn = 0; Similarly, we can leave these as: my $isGit; my $isSvn; r=me.
(In reply to comment #2) > r=me. Thanks! Will update.
Committed: http://trac.webkit.org/changeset/58951