Bug 38723 - JavaScriptCore/wtf/MD5.h: checksum should take a reference to output.
Summary: JavaScriptCore/wtf/MD5.h: checksum should take a reference to output.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Fumitoshi Ukai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-06 22:16 PDT by Fumitoshi Ukai
Modified: 2020-04-30 09:18 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.23 KB, patch)
2010-05-07 00:42 PDT, Fumitoshi Ukai
eric: review+
Details | Formatted Diff | Diff
F3A31F64D894DC06040498CD7383BEC2 (deleted)
2020-04-29 23:38 PDT, alhssan007
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2010-05-06 22:16:44 PDT
md5.checksum() should take a reference to output instead of
returning the result by value.
see https://bugs.webkit.org/show_bug.cgi?id=35572#c7
Comment 1 Fumitoshi Ukai 2010-05-07 00:42:36 PDT
Created attachment 55347 [details]
Patch
Comment 2 Alexey Proskuryakov 2010-05-07 08:35:56 PDT
Comment on attachment 55347 [details]
Patch

I think that checksum() should empty out the vector first, in case a non-empty one was provided by the caller.
Comment 3 Eric Seidel (no email) 2010-05-07 21:56:56 PDT
Comment on attachment 55347 [details]
Patch

You never mention *why* in the ChangeLog, which you should.  I assume this is for performance.
Comment 4 Eric Seidel (no email) 2010-05-08 23:16:48 PDT
Attachment 55347 [details] was posted by a committer and has review+, assigning to Fumitoshi Ukai for commit.
Comment 5 Fumitoshi Ukai 2010-05-10 00:02:51 PDT
Committed r59067: <http://trac.webkit.org/changeset/59067>
Comment 7 Alexey Proskuryakov 2020-04-30 09:18:12 PDT
The content of attachment 398040 [details] has been deleted