Bug 38720 - [Qt] Auto test wont compile from \3rdparty\webkit\WebKit\qt\tests
Summary: [Qt] Auto test wont compile from \3rdparty\webkit\WebKit\qt\tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 420+
Hardware: S60 Emulator S60 3rd edition
: P2 Critical
Assignee: Samuel Nevala
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-05-06 21:56 PDT by Samuel Nevala
Modified: 2010-06-30 01:36 PDT (History)
6 users (show)

See Also:

Attachments
Latest patch (1009 bytes, patch)
2010-06-06 23:39 PDT, Samuel Nevala 		no flags Details | Formatted Diff | Diff
Latest patch (1.01 KB, patch)
2010-06-29 22:20 PDT, Samuel Nevala 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Nevala 2010-05-06 21:56:02 PDT 
Qt: http://qt.gitorious.org/+qt-s60-developers/qt/qt-s60
branch: 4.7
sha: b1225b83282bdeaf7c3847a8f2b3d05e004ce198

Used qt contains webkit from:
webkit: git://gitorious.org/qtwebkit/qtwebkit.git
sha:3f0f51f4c87e65bfe04165c6af4c00934b0ca1e2

Auto test compile from qt\test\auto.

Reproduce:
1. cd qt\src\3rdparty\webkit\WebKit\qt\tests
2. qmake
3. make

Expected: auto tests compile

Result: tst_ are missing from target files in .mmp

Possible fix:
Replace 
!CONFIG(QTDIR_build):TARGET = tst_$$TARGET 
with
!contains(TARGET, ^tst_.*):TARGET = $$join(TARGET,,"tst_")
Comment 1 Jesus Sanchez-Palencia 2010-05-12 07:17:20 PDT 
Simon, would you mind to take a look at this?
Comment 2 Samuel Nevala 2010-06-06 23:39:19 PDT 
Created attachment 57995 [details]
Latest patch
Comment 3 Csaba Osztrogonác 2010-06-22 04:05:48 PDT 
I don't know why, but load(qttest_p4) is missing from tests.pri.

I prefer this line to add into tests.pri,
instead of copy/paste code from qttest_p4.prf:
CONFIG(QTDIR_build): load(qttest_p4)
Comment 4 Samuel Nevala 2010-06-29 22:20:38 PDT 
Created attachment 60084 [details]
Latest patch

Load qttest_p4.prf under QTDIR_build as suggested.
Comment 5 WebKit Commit Bot 2010-06-30 01:36:03 PDT 
Comment on attachment 60084 [details]
Latest patch

Clearing flags on attachment: 60084

Committed r62169: <http://trac.webkit.org/changeset/62169>
Comment 6 WebKit Commit Bot 2010-06-30 01:36:08 PDT 
All reviewed patches have been landed.  Closing bug.