Bug 38717 – REGRESSION(r58933): "Broke all websocket tests on Tiger" (Requested by eseidel on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/58933 broke the build:
"Broke all websocket tests on Tiger" (Requested by eseidel on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 55336 [details]
ROLLOUT of r58933

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

[Eric Seidel (no email)]

Comment on attachment 55336 [details]
ROLLOUT of r58933

Ukai, if you have a fix please feel free to cancel the rollout.

[Fumitoshi Ukai]

(In reply to comment #2)
> (From update of attachment 55336 [details])
> Ukai, if you have a fix please feel free to cancel the rollout.

http://trac.webkit.org/changeset/58933 uses webkitpy to launch websocket server for LayoutTests/websocket/tests, and webkitpy requires python2.5.

Tiger still uses python2.3.
So, I'll wait someone setup python2.5 on tiger bot.
If it's impossible in a few days, I'll just copy pywebsocket 0.5 in webkitpy/thirdparty.

[WebKit Commit Bot]

Comment on attachment 55336 [details]
ROLLOUT of r58933

Clearing flags on attachment: 55336

Committed r58934: <http://trac.webkit.org/changeset/58934>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.