WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
38698
REGRESSION (
r51617
): when plugins are disabled, plugins show up as garbage characters
https://bugs.webkit.org/show_bug.cgi?id=38698
Summary
REGRESSION (r51617): when plugins are disabled, plugins show up as garbage ch...
Anders Carlsson
Reported
2010-05-06 15:17:40 PDT
REGRESSION (
r51617
): when plugins are disabled, plugins show up as garbage characters
Attachments
Patch
(16.43 KB, patch)
2010-05-06 15:28 PDT
,
Anders Carlsson
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2010-05-06 15:28:07 PDT
Created
attachment 55307
[details]
Patch
Darin Adler
Comment 2
2010-05-06 15:31:55 PDT
Comment on
attachment 55307
[details]
Patch
> + if (!allowPlugins && [knownPluginMIMETypes() containsObject:MIMEType]) > + return NO;
What if a plug-in registers for some basic MIME type like text/html? r=me
Anders Carlsson
Comment 3
2010-05-06 15:54:16 PDT
(In reply to
comment #2
)
> (From update of
attachment 55307
[details]
) > > + if (!allowPlugins && [knownPluginMIMETypes() containsObject:MIMEType]) > > + return NO; > > What if a plug-in registers for some basic MIME type like text/html? >
It's not possible to override basic MIME types like text/html. (In theory you're supposed to be able to override image/png etc but from looking at the code that is buggy and nondeterminate.
Anders Carlsson
Comment 4
2010-05-06 16:23:43 PDT
Committed
r58917
: <
http://trac.webkit.org/changeset/58917
>
WebKit Review Bot
Comment 5
2010-05-06 18:03:47 PDT
http://trac.webkit.org/changeset/58917
might have broken Qt Windows 32-bit Release The following changes are on the blame list:
http://trac.webkit.org/changeset/58912
http://trac.webkit.org/changeset/58913
http://trac.webkit.org/changeset/58914
http://trac.webkit.org/changeset/58915
http://trac.webkit.org/changeset/58916
http://trac.webkit.org/changeset/58917
http://trac.webkit.org/changeset/58918
Eric Seidel (no email)
Comment 6
2010-05-06 19:52:48 PDT
I believe either this patch (
http://trac.webkit.org/changeset/58917
) or
http://trac.webkit.org/changeset/58914
caused this failure:
http://build.webkit.org/results/Tiger%20Intel%20Release/r58918%20(11721)/webarchive/test-link-rel-icon-pretty-diff.html
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug