Bug 38698 - REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
Summary: REGRESSION (r51617): when plugins are disabled, plugins show up as garbage ch...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-06 15:17 PDT by Anders Carlsson
Modified: 2010-05-06 19:52 PDT (History)
3 users (show)

See Also:


Attachments
Patch (16.43 KB, patch)
2010-05-06 15:28 PDT, Anders Carlsson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-05-06 15:17:40 PDT
REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
Comment 1 Anders Carlsson 2010-05-06 15:28:07 PDT
Created attachment 55307 [details]
Patch
Comment 2 Darin Adler 2010-05-06 15:31:55 PDT
Comment on attachment 55307 [details]
Patch

> +            if (!allowPlugins && [knownPluginMIMETypes() containsObject:MIMEType])
> +                return NO;

What if a plug-in registers for some basic MIME type like text/html?

r=me
Comment 3 Anders Carlsson 2010-05-06 15:54:16 PDT
(In reply to comment #2)
> (From update of attachment 55307 [details])
> > +            if (!allowPlugins && [knownPluginMIMETypes() containsObject:MIMEType])
> > +                return NO;
> 
> What if a plug-in registers for some basic MIME type like text/html?
> 

It's not possible to override basic MIME types like text/html. (In theory you're supposed to be able to override image/png etc but from looking at the code that is buggy and nondeterminate.
Comment 4 Anders Carlsson 2010-05-06 16:23:43 PDT
Committed r58917: <http://trac.webkit.org/changeset/58917>