Bug 38695 - Missing null check in RenderIFrame::calcWidth() and RenderIFrame::calcHeight()
Summary: Missing null check in RenderIFrame::calcWidth() and RenderIFrame::calcHeight()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ada Chan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-06 14:47 PDT by Ada Chan
Modified: 2010-05-06 18:03 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.49 KB, patch)
2010-05-06 14:52 PDT, Ada Chan 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2010-05-06 14:47:59 PDT 
In RenderIFrame::calcWidth() and RenderIFrame::calcHeight(), we should null check the result from widget() before accessing it.  There's no guarantee that it's not null, and I've seen inconsistently reproducible crashes due to that.
Comment 1 Ada Chan 2010-05-06 14:52:01 PDT 
Created attachment 55302 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2010-05-06 15:36:59 PDT 
Comment on attachment 55302 [details]
Patch

r=me
Comment 3 Ada Chan 2010-05-06 15:53:50 PDT 
Fixed in http://trac.webkit.org/changeset/58915