Bug 38671 - [WTFURL] Add a buffer for managing the output of the canonicalizer
Summary: [WTFURL] Add a buffer for managing the output of the canonicalizer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-06 11:37 PDT by Adam Barth
Modified: 2010-05-08 10:24 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.88 KB, patch)
2010-05-06 11:43 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (6.87 KB, patch)
2010-05-06 12:46 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-05-06 11:37:49 PDT
[WTFURL] Add a buffer for managing the output of the canonicalizer
Comment 1 Adam Barth 2010-05-06 11:43:39 PDT
Created attachment 55280 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2010-05-06 12:30:08 PDT
Comment on attachment 55280 [details]
Patch

JavaScriptCore/wtf/url/src/URLBuffer.h:68
 +      inline int length() const { return m_length; }
nit: no need for the 'inline' keyword here.
Comment 3 Adam Barth 2010-05-06 12:46:25 PDT
Created attachment 55286 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2010-05-08 06:09:46 PDT
Comment on attachment 55286 [details]
Patch for landing

Clearing flags on attachment: 55286

Committed r59024: <http://trac.webkit.org/changeset/59024>
Comment 5 WebKit Commit Bot 2010-05-08 06:09:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Eric Seidel (no email) 2010-05-08 09:30:10 PDT
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r59026%20(9735)/results.html

websocket/tests/frame-length-skip.html seems more likely to time out after this change.  Could this have caused a performance regression?
Comment 7 Adam Barth 2010-05-08 10:24:53 PDT
No.  This code isn't even compiled yet.