RESOLVED FIXED 38671
[WTFURL] Add a buffer for managing the output of the canonicalizer 
https://bugs.webkit.org/show_bug.cgi?id=38671
Summary [WTFURL] Add a buffer for managing the output of the canonicalizer
Adam Barth
Reported 2010-05-06 11:37:49 PDT
[WTFURL] Add a buffer for managing the output of the canonicalizer
Attachments
Patch (6.88 KB, patch)
2010-05-06 11:43 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.87 KB, patch)
2010-05-06 12:46 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-05-06 11:43:39 PDT
Created attachment 55280 [details] Patch
Darin Fisher (:fishd, Google)
Comment 2 2010-05-06 12:30:08 PDT
Comment on attachment 55280 [details] Patch JavaScriptCore/wtf/url/src/URLBuffer.h:68 + inline int length() const { return m_length; } nit: no need for the 'inline' keyword here.
Adam Barth
Comment 3 2010-05-06 12:46:25 PDT
Created attachment 55286 [details] Patch for landing
WebKit Commit Bot
Comment 4 2010-05-08 06:09:46 PDT
Comment on attachment 55286 [details] Patch for landing Clearing flags on attachment: 55286 Committed r59024: <http://trac.webkit.org/changeset/59024>
WebKit Commit Bot
Comment 5 2010-05-08 06:09:52 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 6 2010-05-08 09:30:10 PDT
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r59026%20(9735)/results.html websocket/tests/frame-length-skip.html seems more likely to time out after this change. Could this have caused a performance regression?
Adam Barth
Comment 7 2010-05-08 10:24:53 PDT
No. This code isn't even compiled yet.
Note You need to log in before you can comment on or make changes to this bug.