Bug 38659 - Improve performance of single character string compares
Summary: Improve performance of single character string compares
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-06 10:39 PDT by Oliver Hunt
Modified: 2010-05-06 19:58 PDT (History)
4 users (show)

See Also:


Attachments
Patch (415.17 KB, patch)
2010-05-06 10:45 PDT, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2010-05-06 10:39:12 PDT
Improve performance of single character string compares
Comment 1 Oliver Hunt 2010-05-06 10:45:13 PDT
Created attachment 55262 [details]
Patch
Comment 2 Oliver Hunt 2010-05-06 10:45:49 PDT
Patch is giant due to testcase results -- actual patch is only ~30k
Comment 3 Geoffrey Garen 2010-05-06 11:03:15 PDT
Let's call emit_op_jxlesseq emit_op_jlesseq and have invert default to false.

I'm concerned that a 3 second test might hang some bots. Maybe you can split the test up, or merge the functions into a larger function, so there are fewer parsing/compilation/call passes.
Comment 4 Geoffrey Garen 2010-05-06 11:03:26 PDT
Comment on attachment 55262 [details]
Patch

r=me
Comment 5 Oliver Hunt 2010-05-06 12:40:10 PDT
Committed r58902: <http://trac.webkit.org/changeset/58902>
Comment 6 WebKit Review Bot 2010-05-06 12:48:56 PDT
http://trac.webkit.org/changeset/58902 might have broken Qt Linux ARMv5 Release and Qt Linux ARMv7 Release
Comment 7 Eric Seidel (no email) 2010-05-06 19:45:38 PDT
I think this caused timeouts on the Gtk Bot:
http://build.webkit.org/results/GTK%20Linux%2032-bit%20Debug/r58925%20(5593)/results.html
Comment 8 Eric Seidel (no email) 2010-05-06 19:58:37 PDT
My apologies.  I was mistaken. :(