Bug 38650 – [Gtk]: DRT does not support frame flattening testing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Antonio Gomes]

win, mac and qt does support testing frame flattening, but gtk.

see https://bugs.webkit.org/show_bug.cgi?id=32717 for details

[Antonio Gomes]

Xan, Martin, Gustavo, would you guys be Ok if I added a settings to enable it, like we did for spatial-navigation in bug 35701? If so, I can do it.

[Martin Robinson]

Sure, for things only used in the DRT, this we usually have them as private members of the API at first.

[Antonio Gomes]

Created attachment 70831 [details]
patch v1: API + DRT support + Unskip

[Antonio Gomes]

The documentation added was based on Qt's documentation for similar WebSetting.

[Antonio Gomes]

btw, all frame flattening expected results dump render tree and then are platform specific due to font/pixel differences.

I have the results here. They are similar to Qt's results and will be committed altogether with the patch.

[Martin Robinson]

Comment on attachment 70831 [details]
patch v1: API + DRT support + Unskip

View in context: https://bugs.webkit.org/attachment.cgi?id=70831&action=review

> WebKit/gtk/webkit/webkitwebsettings.cpp:607
> +    * Weither to enable the Frame Flattening. With this setting each subframe is expanded

Should be "Whether" here.

[Martin Robinson]

This looks great to me. Thanks for implementing this! I would give the r+, but we need one other GTK+ reviewer to approve the API change (and possibly double-check the @since line).

[Xan Lopez]

I had never heard of this, but the name of the property seems reasonable.

@since should be 1.3.5, 1.3.0 was released a long time ago.

[Antonio Gomes]

do I hear a r+ with this two issues addressed + the layout test expected files added? :)

[Antonio Gomes]

Created attachment 70951 [details]
(committed r69919, r=mrobinson,xan) patch v2: API + DRT support + Unskip + Expected test results

Fixed:

1) s/Weither/Whether in the documentation;
2) s/1.3.0/1.3.5 for the API version;
3) Added expected results.

[WebKit Review Bot]

Attachment 70951 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
LayoutTests/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antonio Gomes]

(In reply to comment #11)
> Attachment 70951 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
> LayoutTests/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
> Total errors found: 1 in 17 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Fixed locally.

[Martin Robinson]

Comment on attachment 70951 [details]
(committed r69919, r=mrobinson,xan) patch v2: API + DRT support + Unskip + Expected test results

Great. Thanks again!

[Antonio Gomes]

Comment on attachment 70951 [details]
(committed r69919, r=mrobinson,xan) patch v2: API + DRT support + Unskip + Expected test results

Clearing flags on attachment: 70951

Committed r69919: <http://trac.webkit.org/changeset/69919>

[Antonio Gomes]

Proper test expectation results landed in <http://trac.webkit.org/changeset/69921>

[WebKit Review Bot]

http://trac.webkit.org/changeset/69919 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
fast/frames/flattening/frameset-flattening-grid.html
fast/frames/flattening/frameset-flattening-simple.html
fast/frames/flattening/frameset-flattening-subframe-resize.html
fast/frames/flattening/frameset-flattening-subframesets.html
http/tests/inspector/console-xhr-logging.html